This revision was automatically updated to reflect the committed changes.
Closed by commit R241:80ccfabb06ff: Allow move semantics to be generated for
KFileItem. The existing copy… (authored by markg).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
Ah yeah, of course. Can't be inlined, since the impl needs to see the private
class. Forget what I said, out-of-line it is, and yes, do keep the unittest ;)
It at least guards against a
markg added a comment.
In https://phabricator.kde.org/D10341#202720, @markg wrote:
> In https://phabricator.kde.org/D10341#202704, @dfaure wrote:
>
> > I like the idea of enabling moves for KFileItem very much.
> >
> > But here's a fun fact: your unittest passes even without the
markg added a comment.
In https://phabricator.kde.org/D10341#202704, @dfaure wrote:
> I like the idea of enabling moves for KFileItem very much.
>
> But here's a fun fact: your unittest passes even without the rest of the
patch.
>
> PASS : KFileItemTest::testMove()
>
>
dfaure added a comment.
I like the idea of enabling moves for KFileItem very much.
But here's a fun fact: your unittest passes even without the rest of the
patch.
PASS : KFileItemTest::testMove()
That's because std::move() doesn't move, it only makes the argument eligible
markg created this revision.
markg added reviewers: dfaure, mwolff.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
markg requested review of this revision.
REVISION SUMMARY
This allows the compiler to generate:
- Move constructor
