This revision was automatically updated to reflect the committed changes.
Closed by commit R241:e3a80661c9cd: Stuff the "Couldn't find
executable" message box into a queued lambda (authored by hein).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D10405?vs=27048&id=27285#toc
REPOSITORY
hein added a comment.
Thanks!
REPOSITORY
R241 KIO
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10405
To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh
dfaure accepted this revision.
dfaure added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> krun.cpp:1619
> +
> +if (qGuiApp) {
> +QTimer::singleShot(0, qGuiApp, [=]() {
Actually, KMessageBox requires qApp, not just qGuiApp.
(Then
hein added a comment.
ping
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10405
To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh
hein added a comment.
(Side note: I like the idea of a KRun job - something like that could even be
added without needing a KIO 6.)
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10405
To: hein, dfaure, davidedmundson, mart, ngraham
Cc: #frameworks, michaelh
hein updated this revision to Diff 27048.
hein added a comment.
- Fall back to qWarning if !qGuiApp
- Use QTimer::singleShot to work on older Qt
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10405?vs=27046&id=27048
BRANCH
master
REVISION DETAIL
https:/
hein added a comment.
There's a problem with my patch :(. QMetaObject::invokeMethod(context,
functor) is new in Qt 5.10. I don't think we can depend on that yet, right?
Ah, but QTimer::singleShot added an overload w/ context in 5.4 ..
REPOSITORY
R241 KIO
REVISION DETAIL
https://phab
dfaure added inline comments.
INLINE COMMENTS
> krun.cpp:1616
> // (or with a full path, if m_executable is absolute), and then in
> the PATH.
> -if (!QFile(m_executable).exists() &&
> QStandardPaths::findExecutable(m_executable).isEmpty()) {
> -QEventLoopLocker loc
hein retitled this revision from "Don't proceed in runCommandInternal if the
executable doesn't exit" to "Stuff the "Couldn't find executable" message box
into a queued lambda".
hein edited the summary of this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D10405
