D10411: Create socket file in user's runtime directory

2018-06-01 Thread Chinmoy Ranjan Pradhan 
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ae08be3a4847: Create socket file in users runtime 
directory (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10411?vs=33765=35322

REVISION DETAIL
  https://phabricator.kde.org/D10411

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, ossi
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D10411: Create socket file in user's runtime directory

2018-05-27 Thread Oswald Buddenhagen 
ossi accepted this revision.
Restricted Application added a subscriber: kde-frameworks-devel.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10411

To: chinmoyr, #frameworks, ossi
Cc: kde-frameworks-devel, dfaure, michaelh, ngraham, bruns

D10411: Create socket file in user's runtime directory

2018-05-07 Thread Chinmoy Ranjan Pradhan 
chinmoyr reclaimed this revision.
chinmoyr added a comment.
This revision is now accepted and ready to land.


  Sorry, abandoned it by mistake.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10411

To: chinmoyr, #frameworks, ossi
Cc: dfaure, michaelh, ngraham, bruns

D10411: Create socket file in user's runtime directory

2018-05-07 Thread Chinmoy Ranjan Pradhan 
chinmoyr abandoned this revision.
chinmoyr added a comment.


  Split into D12744  and D12745 


REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10411

To: chinmoyr, #frameworks, ossi
Cc: dfaure, michaelh, ngraham, bruns

D10411: Create socket file in user's runtime directory

2018-05-07 Thread Chinmoy Ranjan Pradhan 
chinmoyr added a dependent revision: D12744: Add null pointer check when 
creating SocketAddress.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10411

To: chinmoyr, #frameworks, ossi
Cc: dfaure, michaelh, ngraham, bruns

D10411: Create socket file in user's runtime directory

2018-05-07 Thread Chinmoy Ranjan Pradhan 
chinmoyr updated this revision to Diff 33765.
chinmoyr added a comment.


  Rebased on D10410 

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10411?vs=32414=33765

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10411

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, ossi
Cc: dfaure, michaelh, ngraham, bruns

D10411: Create socket file in user's runtime directory

2018-05-06 Thread Oswald Buddenhagen 
ossi accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10411

To: chinmoyr, #frameworks, ossi
Cc: dfaure, michaelh, ngraham, bruns

D10411: Create socket file in user's runtime directory

2018-04-17 Thread Chinmoy Ranjan Pradhan 
chinmoyr updated this revision to Diff 32414.
chinmoyr edited the summary of this revision.
chinmoyr added a comment.


  Rebased on D10409 

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10411?vs=26832=32414

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10411

AFFECTED FILES
  src/ioslaves/file/file_unix.cpp
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, ossi
Cc: dfaure, michaelh, bruns

D10411: Create socket file in user's runtime directory

2018-03-04 Thread David Faure 
dfaure added a comment.


  That doesn't look like an atomic commit. In this commit, "path" changes from 
relative to absolute, but the caller hasn't been updated to actually send an 
absolute path?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10411

To: chinmoyr, #frameworks, ossi
Cc: dfaure, michaelh

D10411: Create socket file in user's runtime directory

2018-02-09 Thread Chinmoy Ranjan Pradhan 
chinmoyr created this revision.
chinmoyr added reviewers: Frameworks, ossi.
Restricted Application added a project: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  "/tmp" is world writable so creating socket there is a bad idea. Instead 
create socket in user's
  runtime directory or any directory with permissions 0700. This path will be 
provided by file
  ioslave.
  
  Depends on https://phabricator.kde.org/D10410

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10411

AFFECTED FILES
  src/ioslaves/file/sharefd_p.h

To: chinmoyr, #frameworks, ossi
Cc: michaelh, ngraham