D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

2018-02-19 Thread Albert Astals Cid
aacid closed this revision.

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D10445

To: aacid, apol
Cc: #frameworks, michaelh


D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

2018-02-19 Thread Aleix Pol Gonzalez
apol accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10445

To: aacid, apol
Cc: #frameworks, michaelh


D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

2018-02-11 Thread Albert Astals Cid
aacid added a comment.


  together with https://phabricator.kde.org/D10444 fixes 
https://bugs.kde.org/show_bug.cgi?id=390078

REPOSITORY
  R263 KXmlGui

REVISION DETAIL
  https://phabricator.kde.org/D10445

To: aacid
Cc: #frameworks, michaelh


D10445: Improve KSwitchLanguageDialogPrivate::fillApplicationLanguages

2018-02-11 Thread Albert Astals Cid
aacid created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
aacid requested review of this revision.

REVISION SUMMARY
  KLanguageButton::insertLanguage already knows how to figure out the name
  of a language, so no need to do it ourselves

REPOSITORY
  R263 KXmlGui

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10445

AFFECTED FILES
  src/kswitchlanguagedialog_p.cpp

To: aacid
Cc: #frameworks, michaelh