D10518: Use QWidget to see if the window is visible

2018-02-20 Thread Aleix Pol Gonzalez 
This revision was automatically updated to reflect the committed changes.
Closed by commit R289:09e848b68d7c: Use QWidget to see if the window is visible 
(authored by apol).

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10518?vs=27182=27612

REVISION DETAIL
  https://phabricator.kde.org/D10518

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: apol, #frameworks, stikonas
Cc: stikonas, michaelh

D10518: Use QWidget to see if the window is visible

2018-02-14 Thread Andrius Štikonas 
stikonas accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10518

To: apol, #frameworks, stikonas
Cc: stikonas, michaelh

D10518: Use QWidget to see if the window is visible

2018-02-14 Thread Aleix Pol Gonzalez 
apol updated this revision to Diff 27182.
apol removed a reviewer: stikonas.
apol added a comment.
This revision now requires review to proceed.


  Properly detect the window state when not on X11
  
  KWindowInfo doesn't support most features on Wayland (or any other backend)
  so we provide an alternative simpler, dumber path.

REPOSITORY
  R289 KNotifications

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10518?vs=27180=27182

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10518

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: apol, #frameworks
Cc: stikonas, michaelh

D10518: Use QWidget to see if the window is visible

2018-02-14 Thread Andrius Štikonas 
stikonas accepted this revision.
stikonas added a comment.
This revision is now accepted and ready to land.


  Works for me.

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10518

To: apol, #frameworks, stikonas
Cc: stikonas, michaelh

D10518: Use QWidget to see if the window is visible

2018-02-14 Thread Aleix Pol Gonzalez 
apol created this revision.
apol added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
apol requested review of this revision.

REVISION SUMMARY
  Instead of using KWindowInfo::mappingState that won't give reliable
  information about the window on wayland.

TEST PLAN
  tested locally

REPOSITORY
  R289 KNotifications

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10518

AFFECTED FILES
  src/kstatusnotifieritem.cpp

To: apol, #frameworks
Cc: michaelh