D10587: Restore KTextEditor Document Dbus bindings

2018-08-14 Thread Christoph Cullmann
cullmann commandeered this revision. cullmann edited reviewers, added: lukedashjr; removed: cullmann. cullmann added a comment. As said, I agree a fix for the unsaved documents vs. no swap files problem is wanted, but a single use case is not enough to bring back the dbus overhead per

D10587: Restore KTextEditor Document Dbus bindings

2018-08-14 Thread Christoph Cullmann
cullmann abandoned this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10587 To: cullmann, dhaumann, gregormi, lukedashjr Cc: kwrite-devel, kde-frameworks-devel, anthonyfieroni, #ktexteditor, #kate, asturmlechner, gregormi, dhaumann, cullmann, michaelh,

D10587: Restore KTextEditor Document Dbus bindings

2018-07-14 Thread Christoph Cullmann
cullmann requested changes to this revision. cullmann added a comment. This revision now requires changes to proceed. Restricted Application edited subscribers, added: kde-frameworks-devel, kwrite-devel; removed: Frameworks. I still don't agree with having that just for the use-case of

D10587: Restore KTextEditor Document Dbus bindings

2018-02-16 Thread Anthony Fieroni
anthonyfieroni added a comment. In D10587#207885 , @lukedashjr wrote: > I don't think I would know how to make these changes. I was only able to get this to work because it was mostly a simple revert. It should be same: at

D10587: Restore KTextEditor Document Dbus bindings

2018-02-16 Thread Andreas Sturmlechner
asturmlechner added a comment. This change has history, for reference: https://git.reviewboard.kde.org/r/129398/ REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10587 To: lukedashjr, cullmann, dhaumann, gregormi Cc: anthonyfieroni, #ktexteditor, #kate,

D10587: Restore KTextEditor Document Dbus bindings

2018-02-16 Thread Luke Dashjr
lukedashjr added a comment. In D10587#207874 , @anthonyfieroni wrote: > It will not break compatibility or you should supposed how? Kate and KWrite present in same repo, so the code can be shared, but yes it will not have this feature in other

D10587: Restore KTextEditor Document Dbus bindings

2018-02-16 Thread Anthony Fieroni
anthonyfieroni added a comment. It will not break compatibility or you should supposed how? Kate and KWrite present in same repo, so the code can be shared, but yes it will not have this feature in other apps that uses KTextEditor. But you can read @cullmann wrote in bug report that it

D10587: Restore KTextEditor Document Dbus bindings

2018-02-16 Thread Luke Dashjr
lukedashjr added a comment. In D10587#207857 , @anthonyfieroni wrote: > You can try to add DBus in Kate (application) rather than KTextEditor (framework). Won't that break compatibility? (and fail to cover KWrite or other similar

D10587: Restore KTextEditor Document Dbus bindings

2018-02-16 Thread Anthony Fieroni
anthonyfieroni added a comment. You can try to add DBus in Kate (application) rather than KTextEditor (framework). REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D10587 To: lukedashjr, cullmann, dhaumann, gregormi Cc: anthonyfieroni, #ktexteditor, #kate,

D10587: Restore KTextEditor Document Dbus bindings

2018-02-16 Thread Luke Dashjr
lukedashjr created this revision. lukedashjr added reviewers: cullmann, dhaumann, gregormi. lukedashjr added projects: KTextEditor, Kate, Frameworks. Restricted Application added a subscriber: Frameworks. lukedashjr requested review of this revision. REVISION SUMMARY Enable access to the