D10591: forcefully activate popup windows when they open

[Marco Martin]

mart abandoned this revision.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[Marco Martin]

mart added a comment.


  An alternate idea:
  
  - we open it without giging focus
  - the current show time is 5 seconds
  - after 2 seconds (1 would be enough?) we check if there was user activity 
with kidletime
  - if there was activity, if the notifier doesn't contain the cursor or isn't 
focused, then close it
  - otherwise the usual 5 seconds

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[Kai Uwe Broulik]

broulik added a comment.


  If we were to do this, we need to first make Device Notifier not freak out 
when you have a wonky USB cable.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[Marco Martin]

mart added a comment.


  another way, may be adding a default kwin rule or script which lets every 
plasma window go trough

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[Marco Martin]

mart added a comment.


  In D10591#207905 , @davidedmundson 
wrote:
  
  > What would this code do if the device notifier is expanded but on the 
desktop?
  
  
  giving desktop window focus, which means we should also either check window 
flags or the applet formfactor... (tough i would still like a smarter solution)

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[David Edmundson]

davidedmundson added a comment.


  What would this code do if the device notifier is expanded but on the desktop?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10591

To: mart, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10591: forcefully activate popup windows when they open

[Marco Martin]

mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  if an applet is requiresattention, always give the popup focus
  
  rationale is for the devicenotifier which opten opens and is not possible to
  dismiss it by clicking anywhere: unfortunately the only way we have is to
  give it focus, so it can close.
  
  there is probably a more elegant way to do this (and not steal focus)
  maybe a dbus protocol from kwin?

TEST PLAN
  device notifier always gets focus even if input from the current focus
  window is recent

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/activatepopups

REVISION DETAIL
  https://phabricator.kde.org/D10591

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart