D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Michail Vourlakos
This revision was automatically updated to reflect the committed changes. Closed by commit R242:1ff405cca5b3: fix RTL appearance for ComboBox (authored by mvourlakos). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10592?vs=27382=27568

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Safa Alfulaij
safaalfulaij accepted this revision. safaalfulaij added a comment. This revision is now accepted and ready to land. Now since I'm a reviewer, sure :) REPOSITORY R242 Plasma Framework (Library) BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma,

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Michail Vourlakos
mvourlakos added a comment. > Sure. Go ahead and commit. is it possible to give first the green light by accepting the review? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart, safaalfulaij Cc: safaalfulaij,

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Michail Vourlakos
mvourlakos added a reviewer: safaalfulaij. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart, safaalfulaij Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Safa Alfulaij
safaalfulaij added a comment. In D10592#209670 , @mvourlakos wrote: > @safaalfulaij is there a green light for this? Sure. Go ahead and commit. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D10592: fix RTL appearance for ComboBox

2018-02-19 Thread Michail Vourlakos
mvourlakos added a comment. @safaalfulaij is there a green light for this? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai,

D10592: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos marked an inline comment as done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10592 To: mvourlakos, #plasma, mart Cc: safaalfulaij, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D10592: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos updated this revision to Diff 27382. mvourlakos added a comment. - improve semantics REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10592?vs=27373=27382 BRANCH rtl REVISION DETAIL https://phabricator.kde.org/D10592

D10592: fix RTL appearance for ComboBox

2018-02-16 Thread Safa Alfulaij
safaalfulaij added inline comments. INLINE COMMENTS > ComboBox.qml:113 > highlightMoveDuration: 0 > -LayoutMirroring.enabled: true > +// HACK: When the ComboBox is not inside the base Item, it does > not inherit > +// the LayoutMirroring options.

D10592: fix RTL appearance for ComboBox

2018-02-16 Thread Michail Vourlakos
mvourlakos created this revision. mvourlakos added reviewers: Plasma, mart. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mvourlakos requested review of this revision. REVISION SUMMARY - when the combobox isnt