This revision was automatically updated to reflect the committed changes.
Closed by commit R216:933eecb13d9a: Support case-insensitive WordDetect
(authored by dhaumann).
REPOSITORY
R216 Syntax Highlighting
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10646?vs=27496=27959
REVISION
dhaumann added a comment.
Ok, good catch. Given the uninitialized variables in the other classes, this
is good. Will integrate.
REPOSITORY
R216 Syntax Highlighting
BRANCH
word_insensitive
REVISION DETAIL
https://phabricator.kde.org/D10646
To: jpoelen, dhaumann
Cc: dhaumann,
jpoelen added a comment.
It seems that KTextEditor does not have the problem because KateHlWordDetect
is based on KateHlStringDetect which uses the inSensitive parameter.
INLINE COMMENTS
> rule_p.h:249
> QString m_word;
> +Qt::CaseSensitivity m_caseSensitivity;
> };
Yes, but it
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.
In general looks good, and it even revealed a bug as I understand.
However, the KTextEditor framework still has its own implementation of the
syntax highlighting. Can you also
jpoelen created this revision.
jpoelen added a reviewer: dhaumann.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jpoelen requested review of this revision.
REPOSITORY
R216 Syntax Highlighting
BRANCH
word_insensitive
REVISION
