D10671: Fix auto-mount regression

2018-02-20 Thread Dmitry Khlestkov
dkhlestkov added a comment. dsx@yandex.ru REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: ngraham, sefaeyeoglu, rikmills, #frameworks, michaelh

D10671: Fix auto-mount regression

2018-02-20 Thread Nathaniel Graham
ngraham added a comment. In D10671#209941 , @dkhlestkov wrote: > In D10671#209868 , @ngraham wrote: > > > we will need an email address to land this patch if it is accepted > > > How do I prov

D10671: Fix auto-mount regression

2018-02-20 Thread Kai Uwe Broulik
broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I added a similar check in Storage Volume but did not here.. :/ I can confirm that those "Loop Devices" are still ignored, which is good. REPOSITORY R245 Solid REVISION DETAIL ht

D10671: Fix auto-mount regression

2018-02-19 Thread Dmitry Khlestkov
dkhlestkov added a comment. In D10671#209868 , @ngraham wrote: > we will need an email address to land this patch if it is accepted How do I provide it? I see no corresponding input field. REPOSITORY R245 Solid REVISION DETAIL https:

D10671: Fix auto-mount regression

2018-02-19 Thread Nathaniel Graham
ngraham added a comment. FWIW we will need an email address to land this patch if it is accepted. In the future, if you use Arc to submit the patch , this step won't be necessary. REPOSITORY R245 Solid R

D10671: Fix auto-mount regression

2018-02-19 Thread Dmitry Khlestkov
dkhlestkov added a comment. yes, this would be safe REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: rikmills, #frameworks, michaelh

D10671: Fix auto-mount regression

2018-02-19 Thread Rik Mills
rikmills added a comment. I assume this would be safe to backport to 5.43, should it be accepted? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: rikmills, #frameworks, michaelh

D10671: Fix auto-mount regression

2018-02-19 Thread Nathaniel Graham
ngraham added reviewers: Frameworks, broulik. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D10671 To: dkhlestkov, #frameworks, broulik Cc: #frameworks, michaelh

D10671: Fix auto-mount regression

2018-02-19 Thread Dmitry Khlestkov
dkhlestkov created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. dkhlestkov requested review of this revision. REVISION SUMMARY BUG: 389479 Devices with empty path stopped auto-mounting after commit 1384f275ab2f1ad184