D10681: preload the expander (the dialog) too

2018-02-20 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> appletquickitem.cpp:295
> +qint64 time = 0;
> +if (QLoggingCategory::defaultCategory()->isInfoEnabled()) {
> +time = QDateTime::currentMSecsSinceEpoch();

You should check the PlasmaQuick category, not the default one

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D10681

To: mart, #plasma, davidedmundson
Cc: broulik, davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10681: preload the expander (the dialog) too

2018-02-20 Thread Marco Martin 
This revision was automatically updated to reflect the committed changes.
Closed by commit R242:8346b3e76ab8: preload the expander (the dialog) too 
(authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D10681?vs=27605=27606#toc

REPOSITORY
  R242 Plasma Framework (Library)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10681?vs=27605=27606

REVISION DETAIL
  https://phabricator.kde.org/D10681

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10681: preload the expander (the dialog) too

2018-02-20 Thread David Edmundson 
davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> appletquickitem.cpp:294
> +{
> +qint64 time = QDateTime::currentMSecsSinceEpoch();
> +createFullRepresentationItem();

wrap this line in QLoggingCategory::isInfoEnabled

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/preload

REVISION DETAIL
  https://phabricator.kde.org/D10681

To: mart, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10681: preload the expander (the dialog) too

2018-02-20 Thread Marco Martin 
mart created this revision.
mart added a reviewer: Plasma.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  when preloading, preload the expander as well, and reparent the
  full representation to it, so we have a scene schanged less.
  also do a create() of that window (may be worth to do create()
  automatically in every Dialog?)

TEST PLAN
  the first open is visibly a lot faster now

REPOSITORY
  R242 Plasma Framework (Library)

BRANCH
  phab/preload

REVISION DETAIL
  https://phabricator.kde.org/D10681

AFFECTED FILES
  src/plasmaquick/appletquickitem.cpp
  src/plasmaquick/private/appletquickitem_p.h

To: mart, #plasma
Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart