D10702: BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-21 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks! Still gotta remove "BUG: 390748" from the title, though.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin
Cc: ngraham, #frameworks, michaelh

D10702: BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car 
meven added a reviewer: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin
Cc: ngraham, #frameworks, michaelh

D10702: BUG: 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car 
meven retitled this revision from "bug 390748 Always use a job to delete files 
to avoid freezing process waiting on IO" to "BUG: 390748 Always use a job to 
delete files to avoid freezing process waiting on IO".

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham
Cc: ngraham, #frameworks, michaelh

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car 
meven edited the summary of this revision.
meven edited reviewers, added: ngraham; removed: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, dfaure, ngraham, #dolphin
Cc: ngraham, #frameworks, michaelh

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car 
meven edited the summary of this revision.
meven edited the test plan for this revision.
meven added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, #dolphin, dfaure
Cc: ngraham, #frameworks, michaelh

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Nathaniel Graham 
ngraham added a comment.


  Thanks for the patch! Please remove "bug 390748" from the title and instead 
add "BUG: 390748" to its own line in the Summary section. See 
https://community.kde.org/Infrastructure/Phabricator#Formatting_your_patch

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, #dolphin
Cc: ngraham, #frameworks, michaelh

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Nathaniel Graham 
ngraham added a reviewer: Dolphin.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks, #dolphin
Cc: #frameworks, michaelh

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Nathaniel Graham 
ngraham added a reviewer: Frameworks.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10702

To: meven, #frameworks
Cc: #frameworks, michaelh

D10702: bug 390748 Always use a job to delete files to avoid freezing process waiting on IO

2018-02-20 Thread Méven Car 
meven created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
meven requested review of this revision.

REPOSITORY
  R241 KIO

BRANCH
  bug-390748-make-kio-delete-asynchronous

REVISION DETAIL
  https://phabricator.kde.org/D10702

AFFECTED FILES
  src/core/deletejob.cpp

To: meven
Cc: #frameworks, michaelh