D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R241:ec4df175be47: Store PolicyKit action which the slave is 
authorized to perform (authored by chinmoyr).

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10818?vs=31249=31250

REVISION DETAIL
  https://phabricator.kde.org/D10818

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 31249.
chinmoyr added a comment.


  Rearranged member vars

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10818?vs=31227=31249

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10818

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr added inline comments.

INLINE COMMENTS

> slavebase.cpp:129
>  int m_privilegeOperationStatus;
> +QSet m_tempAuths;
>  

@dfaure  where should I place this variable? Just before "m_confirmationAsked"?

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10818

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 31227.
chinmoyr added a comment.


  Rebased on D10568 
  Merged D10437 

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10818?vs=28537=31227

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10818

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h
  src/ioslaves/file/file_unix.cpp

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, ngraham

D10818: Store PolicyKit action which the slave is authorized to perform

[David Faure]

dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Looks ok, but this commit is a bit too small ;) It would make more sense to 
integrate this with the code that's calling addTemporaryAuthorization, so we 
can see how that all works.

REPOSITORY
  R241 KIO

BRANCH
  D10818

REVISION DETAIL
  https://phabricator.kde.org/D10818

To: chinmoyr, dfaure
Cc: #frameworks, michaelh

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr updated this revision to Diff 28537.
chinmoyr added a comment.


  m_TempAuth -> m_temAuths

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10818?vs=27990=28537

BRANCH
  D10818

REVISION DETAIL
  https://phabricator.kde.org/D10818

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h

To: chinmoyr, dfaure
Cc: #frameworks, michaelh

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10437: Update file ioslave's temporary 
authorization list.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10818

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependency: D10568: Handle privilege operation confirmation 
prompts in SlaveBase.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10818

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr added a dependent revision: D10820: Send slave's polkit authorization 
status to the host.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D10818

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski

D10818: Store PolicyKit action which the slave is authorized to perform

[Chinmoy Ranjan Pradhan]

chinmoyr created this revision.
chinmoyr added a reviewer: dfaure.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
chinmoyr requested review of this revision.

REVISION SUMMARY
  After storing the actions it can be decided whether to kill the slave or not.

REPOSITORY
  R241 KIO

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D10818

AFFECTED FILES
  src/core/slavebase.cpp
  src/core/slavebase.h

To: chinmoyr, dfaure
Cc: #frameworks, michaelh, kmorwinski