D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-21 Thread Phil Stefan
pstefan abandoned this revision.
pstefan added a comment.


  Moved to D14971 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: gladhorn, broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, 
mart, ngraham, michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-20 Thread Nathaniel Graham
ngraham added a subscriber: gladhorn.
ngraham added a comment.


  In D10937#311297 , @bruns wrote:
  
  > I think this works better if you actually rotate the screen:
  >  F6203935: rotate2.png 
  
  
  In KScreen, we recently did something similar and just used fully-rotated 
versions:
  
  F6206188: Rotation.png 
  
  This works well because when the screen is physically rotated already, it 
becomes really easy to select the right choice because only one of them has an 
icon that looks like it's oriented correctly. We might want to consider doing 
the same here. So the icons that depict rotation wouldn't need to have rotation 
arrows or windows that were turned at funny angles; they'd simply be depict the 
final rotation state. In which case, the "base" of the screen should probably 
show up on the side that the display has been rotated towards, too.
  
  As for moving the icons into the Plasma theme, I approve, but I think that 
should be done //first// and in a separate commit/patch. (The location is 
https://cgit.kde.org/plasma-framework.git/tree/src/desktoptheme/breeze/icons).So
 you would submit one patch to move the icons into the plasma theme, then a 
second to remove them here (which is safe because `breeze-icons` and 
`plasma-frameworks` have the same release schedules), and then in a third 
patch, you'd replace the existing icons with your awesome new ones.
  
  Does that sound like a reasonable plan? Please let me know how I can help you 
with that. If we're going to make the move, we need to do it fairly soon so 
that both changes (moving to plasma theme and also improving the icons) land in 
KDE Frameworks 5.50, which is going to be the version that Plasma 5.14 depends 
on.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: gladhorn, broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, 
mart, ngraham, michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-18 Thread Stefan Brüns
bruns added a comment.


  I think this works better if you actually rotate the screen:
  F6203935: rotate2.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-14 Thread Phil Stefan
pstefan added a comment.


  Sure, I can do that, but I'd like to get feedback on the final form first :)

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-14 Thread Kai Uwe Broulik
broulik added a comment.


  While you're at it can't you move them to plasma-framework? Having them in 
Breeze makes it not work with other themes and also they are only shown in the 
context of Plasma anyway

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: broulik, bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-08-14 Thread Phil Stefan
pstefan added a comment.


  Sorry folks for the endless period of no activity. After some talking with 
ngraham I removed the laptop metaphor for a much more general standalone 
display. Also the projection screen was swapped out.
  
  My last feedback was that the window icons were too detailed. So I made 3 
version. (Old) fully detailed, some details and no details (well, safe for the 
window buttons :)
  
  F6193072: detailed.png 
  
  F6193074: medium-detailed.png 
  
  F6193073: empty.png 

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-06-12 Thread Nathaniel Graham
ngraham added a comment.


  @pstefan, any update? It would be a shame to let this amazing work languish!

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, 
michaelh, crozbo, firef, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-10 Thread Stefan Brüns
bruns added a comment.


  Two remarks regarding the rotation icons:
  
  1. I would remove the keyboard from the icons - you will use these with a 
tablet, a 2-in-1, or a pivoted external display.
  
  2. For the large versions, rotate the content pictogram/window not by ~20 
degres, but ~70 degrees. Think of holding e.g. a tablet. You will typically 
rotate the screen first, and then rotate the contents back. If rotated by 70 
deg, the shown content will be upright.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-10 Thread Andres Betts
abetts added a comment.


  In D10937#260688 , @pstefan wrote:
  
  > In D10937#260289 , @abetts wrote:
  >
  > > In D10937#260277 , @ngraham 
wrote:
  > >
  > > > Someone will need to land the changes for you. I'd prefer a few more 
thumbs up first. @abetts, are you good with these?
  > >
  > >
  > > I am linking these a lot. I am "almost" there with the designs. I would 
just ask that the center image of the sample window be simplified. I think it 
has a lot of detail. Maybe we can tone it down by removing some elements and 
making the window look more simple.
  >
  >
  > Could you give me more examples of what you'd remove?  As in direction.
  
  
  I would remove the user image and the text representation. Make the window 
title bar bigger. Just leave it blank.
  
  > 
  > 
  >> Icons 5-6 have a representation that is meant to be a second screen, or a 
projector screen? Can you tell me what it is meant to represent?
  > 
  > It's supposed to be a projector screen. I took the original icon metaphor 
to be a projector screen, so I continued with that.
  
  For the projector idea, I am a bit split, because my experience tells me that 
in most cases people are just adding another monitor and not a projector, 
except when they are presenting in front of an audience. Adding an extra 
monitor is a more common situation than a presentation IMHO. Therefore, I 
wonder if you could provide an alternative design where you have a screen 
representation instead of a projector? Just to see the contrast.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-10 Thread Stefan Brüns
bruns added a comment.


  In D10937#260688 , @pstefan wrote:
  
  > It's supposed to be a projector screen. I took the original icon metaphor 
to be a projector screen, so I continued with that.
  
  
  I think you should remove the tripod - I have not seen a projector screen not 
mounted directly to a wall for a long time. IMHO, the tripod adds only clutter, 
but no information.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: bruns, #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-10 Thread Phil Stefan
pstefan added a comment.


  In D10937#260289 , @abetts wrote:
  
  > In D10937#260277 , @ngraham 
wrote:
  >
  > > Someone will need to land the changes for you. I'd prefer a few more 
thumbs up first. @abetts, are you good with these?
  >
  >
  > I am linking these a lot. I am "almost" there with the designs. I would 
just ask that the center image of the sample window be simplified. I think it 
has a lot of detail. Maybe we can tone it down by removing some elements and 
making the window look more simple.
  
  
  Could you give me more examples of what you'd remove?  As in direction.
  
  > Icons 5-6 have a representation that is meant to be a second screen, or a 
projector screen? Can you tell me what it is meant to represent?
  
  It's supposed to be a projector screen. I took the original icon metaphor to 
be a projector screen, so I continued with that.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-09 Thread Andres Betts
abetts added a comment.


  In D10937#260277 , @ngraham wrote:
  
  > Someone will need to land the changes for you. I'd prefer a few more thumbs 
up first. @abetts, are you good with these?
  
  
  I am linking these a lot. I am "almost" there with the designs. I would just 
ask that the center image of the sample window be simplified. I think it has a 
lot of detail. Maybe we can tone it down by removing some elements and making 
the window look more simple.
  
  Icons 5-6 have a representation that is meant to be a second screen, or a 
projector screen? Can you tell me what it is meant to represent?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-09 Thread Nathaniel Graham
ngraham edited the summary of this revision.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-09 Thread Nathaniel Graham
ngraham added a subscriber: VDG.
ngraham added a comment.


  Someone will need to land the changes for you. I'd prefer a few more thumbs 
up first. @abetts, are you good with these?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: #vdg, kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, 
michaelh, crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-05-09 Thread Phil Stefan
pstefan added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel; 
removed: Frameworks.


  Hello again,
  
  I was just wondering if there's something left I have to do now? Like some 
button I have to press or something.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: kde-frameworks-devel, emateli, abetts, mart, ngraham, davidc, michaelh, 
crozbo, firef, bruns, alexeymin, skadinna, aaronhoneycutt, mbohlender, 
#frameworks


D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-05 Thread Phil Stefan
pstefan updated this revision to Diff 31376.

REPOSITORY
  R266 Breeze Icons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10937?vs=28315=31376

REVISION DETAIL
  https://phabricator.kde.org/D10937

AFFECTED FILES
  icons-dark/applets/128/osd-duplicate.svg
  icons-dark/applets/128/osd-rotate-ccw.svg
  icons-dark/applets/128/osd-rotate-cw.svg
  icons-dark/applets/128/osd-rotate-flip.svg
  icons-dark/applets/128/osd-rotate-normal.svg
  icons-dark/applets/128/osd-sbs-left.svg
  icons-dark/applets/128/osd-sbs-sright.svg
  icons-dark/applets/128/osd-shutd-laptop.svg
  icons-dark/applets/128/osd-shutd-screen.svg
  icons-dark/applets/256/osd-duplicate.svg
  icons-dark/applets/256/osd-rotate-ccw.svg
  icons-dark/applets/256/osd-rotate-cw.svg
  icons-dark/applets/256/osd-rotate-flip.svg
  icons-dark/applets/256/osd-rotate-normal.svg
  icons-dark/applets/256/osd-sbs-left.svg
  icons-dark/applets/256/osd-sbs-sright.svg
  icons-dark/applets/256/osd-shutd-laptop.svg
  icons-dark/applets/256/osd-shutd-screen.svg
  icons-dark/applets/32/osd-duplicate.svg
  icons-dark/applets/32/osd-rotate-ccw.svg
  icons-dark/applets/32/osd-rotate-cw.svg
  icons-dark/applets/32/osd-rotate-flip.svg
  icons-dark/applets/32/osd-rotate-normal.svg
  icons-dark/applets/32/osd-sbs-left.svg
  icons-dark/applets/32/osd-sbs-sright.svg
  icons-dark/applets/32/osd-shutd-laptop.svg
  icons-dark/applets/32/osd-shutd-screen.svg
  icons-dark/applets/48/osd-duplicate.svg
  icons-dark/applets/48/osd-rotate-ccw.svg
  icons-dark/applets/48/osd-rotate-cw.svg
  icons-dark/applets/48/osd-rotate-flip.svg
  icons-dark/applets/48/osd-rotate-normal.svg
  icons-dark/applets/48/osd-sbs-left.svg
  icons-dark/applets/48/osd-sbs-sright.svg
  icons-dark/applets/48/osd-shutd-laptop.svg
  icons-dark/applets/48/osd-shutd-screen.svg
  icons-dark/applets/64/osd-duplicate.svg
  icons-dark/applets/64/osd-rotate-ccw.svg
  icons-dark/applets/64/osd-rotate-cw.svg
  icons-dark/applets/64/osd-rotate-flip.svg
  icons-dark/applets/64/osd-rotate-normal.svg
  icons-dark/applets/64/osd-sbs-left.svg
  icons-dark/applets/64/osd-sbs-sright.svg
  icons-dark/applets/64/osd-shutd-laptop.svg
  icons-dark/applets/64/osd-shutd-screen.svg
  icons/applets/128/osd-duplicate.svg
  icons/applets/128/osd-rotate-ccw.svg
  icons/applets/128/osd-rotate-cw.svg
  icons/applets/128/osd-rotate-flip.svg
  icons/applets/128/osd-rotate-normal.svg
  icons/applets/128/osd-sbs-left.svg
  icons/applets/128/osd-sbs-sright.svg
  icons/applets/128/osd-shutd-laptop.svg
  icons/applets/128/osd-shutd-screen.svg
  icons/applets/256/osd-duplicate.svg
  icons/applets/256/osd-rotate-ccw.svg
  icons/applets/256/osd-rotate-cw.svg
  icons/applets/256/osd-rotate-flip.svg
  icons/applets/256/osd-rotate-normal.svg
  icons/applets/256/osd-sbs-left.svg
  icons/applets/256/osd-sbs-sright.svg
  icons/applets/256/osd-shutd-laptop.svg
  icons/applets/256/osd-shutd-screen.svg
  icons/applets/32/osd-duplicate.svg
  icons/applets/32/osd-rotate-ccw.svg
  icons/applets/32/osd-rotate-cw.svg
  icons/applets/32/osd-rotate-flip.svg
  icons/applets/32/osd-rotate-normal.svg
  icons/applets/32/osd-sbs-left.svg
  icons/applets/32/osd-sbs-sright.svg
  icons/applets/32/osd-shutd-laptop.svg
  icons/applets/32/osd-shutd-screen.svg
  icons/applets/48/osd-duplicate.svg
  icons/applets/48/osd-rotate-ccw.svg
  icons/applets/48/osd-rotate-cw.svg
  icons/applets/48/osd-rotate-flip.svg
  icons/applets/48/osd-rotate-normal.svg
  icons/applets/48/osd-sbs-left.svg
  icons/applets/48/osd-sbs-sright.svg
  icons/applets/48/osd-shutd-laptop.svg
  icons/applets/48/osd-shutd-screen.svg
  icons/applets/64/osd-duplicate.svg
  icons/applets/64/osd-rotate-ccw.svg
  icons/applets/64/osd-rotate-cw.svg
  icons/applets/64/osd-rotate-flip.svg
  icons/applets/64/osd-rotate-normal.svg
  icons/applets/64/osd-sbs-left.svg
  icons/applets/64/osd-sbs-sright.svg
  icons/applets/64/osd-shutd-laptop.svg
  icons/applets/64/osd-shutd-screen.svg

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Nathaniel Graham
ngraham added a comment.


  In D10937#240070 , @pstefan wrote:
  
  > I am glad you like them :)
  >
  > I will hand in the updated diff tomorrow. The color fix script somehow ate 
my icons and I have to restore them from a backup.
  
  
  You can download them from this diff, if they're current.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Andres Betts
abetts added a comment.


  I don't have any objections. Good work!
  
  +1

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Phil Stefan
pstefan added a comment.


  I am glad you like them :)
  
  I will hand in the updated diff tomorrow. The color fix script somehow ate my 
icons and I have to restore them from a backup.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Heh, I don't think anyone is ever going to want to use 16x16 versions of 
these in the first place, so I can live with that.
  
  These icons look fantastic. Big +1 from me. Any other comments?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze, ngraham
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-04-04 Thread Phil Stefan
pstefan added a comment.


  Latest revision:
  F5787871: pls_assess.png 
  I moved the window a bit up while maintaining the alignment, as requested. I 
had to remove the stand of the projector screen tho. Originally I "cheated" and 
moved the stand off-center to make it still visible. However, with the "header" 
of the projector screen shown, it was easily apparent that the stand wasn't 
centered anymore.
  
  As for the 16px icons … I say they can't be done. At least for the 5th row 
from the left onward. There simply is not enough room to squeeze two windows 
(as in, window icons) next to each other while 1. having them look like windows 
and 2. being meaningful.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Nathaniel Graham
ngraham added a comment.


  In D10937#227537 , @pstefan wrote:
  
  > In D10937#227525 , @ngraham 
wrote:
  >
  > > Those all look pretty great to me, honestly. A nice upgrade from the 
current icons.
  > >
  > > For the pink column, does it look bad if you raise the projection screen 
so that it's only a little bit higher than the laptop on the large icons? It 
seems like there's room to raise it a bit and still keep the blue window 
aligned between them. I think it's okay if they're not aligned on the smaller 
versions.
  >
  >
  > You mean like in the smaller icons or like so:
  
  
  Like in the smaller icons, but with the blue window aligned due to the extra 
space. If you tried that and it didn't work, no biggie.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Phil Stefan
pstefan added a comment.


  In D10937#227525 , @ngraham wrote:
  
  > Those all look pretty great to me, honestly. A nice upgrade from the 
current icons.
  >
  > For the pink column, does it look bad if you raise the projection screen so 
that it's only a little bit higher than the laptop on the large icons? It seems 
like there's room to raise it a bit and still keep the blue window aligned 
between them. I think it's okay if they're not aligned on the smaller versions.
  
  
  You mean like in the smaller icons or like so:
  F5756076: path1394.png ?
  
  In D10937#227527 , @emateli wrote:
  
  > Hi, while I do appreciate the icons I also have a question: Why the use of 
laptop and projector over of two simple generic screens. Wouldn't that be 
better for all use cases?
  
  
  Dunno, I didn't set out to change the metaphors used.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Emirald Mateli
emateli added a comment.


  Hi, while I do appreciate the icons I also have a question: Why the use of 
laptop and projector over of two simple generic screens. Wouldn't that be 
better for all use cases?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: emateli, abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, 
firef, alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Nathaniel Graham
ngraham added a comment.


  Those all look pretty great to me, honestly. A nice upgrade from the current 
icons.
  
  For the pink column, does it look bad if you raise the projection screen so 
that it's only a little bit higher than the laptop on the large icons? It seems 
like there's room to raise it a bit and still keep the blue window aligned 
between them. I think it's okay if they're not aligned on the smaller versions.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, 
alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-16 Thread Phil Stefan
pstefan added a comment.


  An update:
  F5756024: thick_or_Thipng.png 
  
  Green column:
  I still haven't found a better metaphor.  With the slightly rotated window 
metaphors to its sides I can just leave out the window at smaller sizes, but I 
can't really think of something that fills the screen at larger sizes while 
still being expressive at smaller sized.
  
  Pink column:
  I tried to get rid of the skew, but at medium sizes I can't seem to manage to 
get something that 1. doesn't look like a potato and 2. is actually 
recognizable. The laptop isn't so much the issue as the second screen.
  
  Orange row:
  I am honestly not sure it can be done at this size. The first 4 icons are 
probably possible, but after that it gets extremely tricky. I haven't managed 
to find forms that are clear in their meaning and still recognizable. It's 
either super cluttered or just a blue rectangle and a red X :|
  
  I already had to get rid of the outer rim around the laptop in the 3rd row 
5th column onward. I am not a fan.
  
  As for the last row: I found that just scaling everything by a factor of 2 
works best. With a 1px line thickness things start to look "hollow" and 
incomplete.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, 
alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-01 Thread Andres Betts
abetts added a comment.


  Is there a way that we can add extra clarity by adding a label below the 
icons? A label that explains what the action is? I agree that the current 
symbolism can be hard to read but it is also very simple. If you make the 
connection to label, it will be even stronger in meaning. Also, not sure I like 
the white background on those tiles, is there a way that they can be dark and 
the images light? Just a thought on colors.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: abetts, mart, ngraham, #frameworks, davidc, michaelh, crozbo, firef, 
alexeymin, skadinna, aaronhoneycutt, mbohlender


D10937: Retouching of Screen Layout Selection OSD Icons

2018-03-01 Thread Nathaniel Graham
ngraham added a comment.


  Thanks for this patch!
  
  I like that the laptop and projector screen icons look better with your 
versions and don't have line weights that are as thick, which returns the focus 
to the icons that they're displaying. And I like that the arrows now have 
appropriate head sizes. The three left-most icons looks just about perfect to 
me.
  
  But I don't like how the window and X icons in the other icons are now much 
lighter and smaller. I feel like they need to be a bit bigger and/or have 
thicker line weights to ensure that they don't recede too much in visual 
importance. Maybe not as big and thick as before, but maybe a //bit// bigger.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D10937

To: pstefan, #breeze
Cc: ngraham, #frameworks, davidc, michaelh, crozbo, firef, alexeymin, skadinna, 
aaronhoneycutt, mbohlender