D11013: Detect incorrect paramenter in findProtocol
This revision was automatically updated to reflect the committed changes. Closed by commit R241:287093136efc: Detect incorrect paramenter in findProtocol (authored by jtamate). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D11013?vs=28679&id=32168#toc REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11013?vs=28679&id=32168 REVISION DETAIL https://phabricator.kde.org/D11013 AFFECTED FILES src/core/kprotocolinfofactory.cpp To: jtamate, #frameworks, dfaure Cc: michaelh, ngraham, bruns
D11013: Detect incorrect paramenter in findProtocol
dfaure accepted this revision. dfaure added a comment. This revision is now accepted and ready to land. Yes, but please don't push this until you have fixed the caller in your testcase, and used a Plasma/KF5 session with these asserts enabled for 2 weeks. Thanks ;) REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11013 To: jtamate, #frameworks, dfaure Cc: michaelh
D11013: Detect incorrect paramenter in findProtocol
jtamate added a dependent revision: D11044: Don't try to find an icon for an empty url. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11013 To: jtamate, #frameworks, dfaure Cc: michaelh
D11013: Detect incorrect paramenter in findProtocol
jtamate updated this revision to Diff 28679. jtamate retitled this revision from "Remove trailing data in the protocol parameter in findProtocol" to "Detect incorrect paramenter in findProtocol". jtamate edited the summary of this revision. jtamate edited the test plan for this revision. jtamate added a comment. I've detected so far only the case of KProtocolInfo::icon with "", in a dependent revision. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11013?vs=28566&id=28679 REVISION DETAIL https://phabricator.kde.org/D11013 AFFECTED FILES src/core/kprotocolinfofactory.cpp To: jtamate, #frameworks, dfaure Cc: michaelh
