dfaure added inline comments.
INLINE COMMENTS
> jtamate wrote in kurlcompletion.cpp:626
> I missed one key stroke. With this test, in a non empty current dirt, it
> fails.
>
> void KUrlCompletionTest::testInvalidProtocol()
> {
>
> KUrlCompletion* completionHomeCwd = new KUrlCompletion;
>
jtamate added inline comments.
INLINE COMMENTS
> dfaure wrote in kurlcompletion.cpp:626
> I'm not 100% sure about this one because kurl() is only supposed to be called
> if url.isURL().
>
> Also, I tried to reproduce this assert with a unittest for kcompletion, but
> it works here !?
>
>
dfaure requested changes to this revision.
dfaure added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kprotocolmanager.cpp:1141
> +}
> KProtocolInfoPrivate *prot = findProtocol(url);
> if (!prot) {
You could move the check to inside
jtamate added a comment.
The backtraces:
deleting characters from the beginning
#10 0x7fdc893f249a in KProtocolInfoFactory::findProtocol
(this=0x7fdc896b9720 <(anonymous
namespace)::Q_QGS_kProtocolInfoFactoryInstance::innerFunction()::holder>,
protocol=...) at
jtamate created this revision.
jtamate added reviewers: Frameworks, dfaure.
Restricted Application added a project: Frameworks.
jtamate requested review of this revision.
REVISION SUMMARY
deleting characters from the beginning in a url in dolphin
trying to use this url: ~:/
REPOSITORY
R241
