D11097: [Window Thumbnail] Allow using atlas texture
davidedmundson added a comment. Edit. Just re-read. Sorry. createTextureFromId with CanUseAtlas doesn't make any sense. It creates a QSGTexture object from an existing GL Texture, it's not creating any atlas or otherwise. It'll just no-op. So no harm done. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11097 To: broulik, #plasma, davidedmundson Cc: #frameworks, michaelh
D11097: [Window Thumbnail] Allow using atlas texture
This revision was automatically updated to reflect the committed changes. Closed by commit R242:48771a291229: [Window Thumbnail] Allow using atlas texture (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11097?vs=28832&id=28834 REVISION DETAIL https://phabricator.kde.org/D11097 AFFECTED FILES src/declarativeimports/core/windowthumbnail.cpp To: broulik, #plasma, davidedmundson Cc: #frameworks, michaelh
D11097: [Window Thumbnail] Allow using atlas texture
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11097 To: broulik, #plasma, davidedmundson Cc: #frameworks, michaelh
D11097: [Window Thumbnail] Allow using atlas texture
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. broulik requested review of this revision. REVISION SUMMARY It's not using any custom shaders anyway TEST PLAN Verified thumbnails still look good Verified fallback to window icon still looks good REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D11097 AFFECTED FILES src/declarativeimports/core/windowthumbnail.cpp To: broulik, #plasma Cc: #frameworks, michaelh
