D11236: [KCrash] Establish socket to allow change of ptrace scope

ossi added a comment. In D11236#393789 , @ossi wrote: > detaching via double fork() "protects" the child process, > but does *not* break the permission inheritance. ok, i take that back and claim the opposite - i misinterpreted

D11236: [KCrash] Establish socket to allow change of ptrace scope

ossi added a comment. In D11236#393720 , @croick wrote: > Actually it's only the internal process that creates the backtraces, that is a descendant of DrKonqi. All debuggers that are launched via the "Debug" button are processes on their own

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick added a comment. In D11236#393063 , @ossi wrote: > yay, i finally have "some" time for this. ^^ Great! :) And thanks for your input. > it took me a while to get a coherent picture of the problem and solution, because your

D11236: [KCrash] Establish socket to allow change of ptrace scope

ossi requested changes to this revision. ossi added a comment. This revision now requires changes to proceed. yay, i finally have "some" time for this. ^^ it took me a while to get a coherent picture of the problem and solution, because your description unnecessarily dwells on the

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 43560. croick added a comment. - Use empty body for while loop REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=43020=43560 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11236 AFFECTED FILES

D11236: [KCrash] Establish socket to allow change of ptrace scope

dfaure added a reviewer: ossi. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks, ossi Cc: dfaure, lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptrace scope

dfaure added a comment. This looks like the kind of commit where a review by Oswald Buddenhagen would be useful. INLINE COMMENTS > kcrash.cpp:672 > +// wait while DrKonqi is running and the socket connection > exists > +while (kill(pid, 0) >= 0 &&

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 43020. croick added a comment. - check for interrupted signal calls when polling - create path string to socket only once - add comments REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=34673=43020 BRANCH

D11236: [KCrash] Establish socket to allow change of ptrace scope

sitter added a subscriber: lepagevalleeemmanuel. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks Cc: lepagevalleeemmanuel, kde-frameworks-devel, sitter, michaelh, ngraham, bruns

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick added a comment. Is there anybody who feels like reviewing this? I'm happily using the patch on my system, but I understand that there might still be hidden issues here. REPOSITORY R285 KCrash REVISION DETAIL https://phabricator.kde.org/D11236 To: croick, #frameworks Cc:

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 34673. croick added a comment. - remove superfluous line... REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=34672=34673 BRANCH ptracer REVISION DETAIL https://phabricator.kde.org/D11236 AFFECTED FILES

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 34672. croick added a comment. Restricted Application added a subscriber: kde-frameworks-devel. - use `QDir::tempPath()` REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=31244=34672 BRANCH ptracer REVISION

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick added a comment. In D11236#239055 , @sitter wrote: > Maybe I am missing something here but wouldn't this allow any application to get ptrace access? > > e.g. if a malicious program watches /tmp/kcrash_*, then writes its own pid to a

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 31244. croick added a comment. - check for peer PID to restrict socket connection to DrKonqi - add ifdefs to deactivate code for non-linuxes REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=30980=31244 BRANCH

D11236: [KCrash] Establish socket to allow change of ptrace scope

sitter added a comment. Maybe I am missing something here but wouldn't this allow any application to get ptrace access? e.g. if a malicious program watches /tmp/kcrash_*, then writes its own pid to a new socket before kcrash writes the debugger's... now the malicious program has ptrace

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick updated this revision to Diff 30980. croick added a comment. - change socket file location and delete file after use REPOSITORY R285 KCrash CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11236?vs=29248=30980 BRANCH ptracer REVISION DETAIL

D11236: [KCrash] Establish socket to allow change of ptrace scope

croick created this revision. croick added a reviewer: Frameworks. Restricted Application added a project: Frameworks. croick requested review of this revision. REVISION SUMMARY - In Linux recent kernels only allow attaching of processes to a debugger, if - the right to attach to processes