D11290: [UDevManager] Already filter for subsystem before querying

mpyne added a comment. I never had the bug myself, I just grepped through the attached log to see if it made sense or not. :) I'll close the bug for now, if it doesn't fix the issue then it'll just get reopened. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290

D11290: [UDevManager] Already filter for subsystem before querying

broulik added a comment. I wasn't sure if that really fixes it, it might mitigate it? If you could perhaps retry with your strace skills. If you consider it good enough, feel free to close the bug REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #fr

D11290: [UDevManager] Already filter for subsystem before querying

mpyne added a comment. Any reason not to close the bug 391738? I can do so but wanted to make sure it wasn't intentionally left open. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #frameworks, davidedmundson Cc: mpyne, ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

This revision was automatically updated to reflect the committed changes. Closed by commit R245:3b642556c203: [UDevManager] Already filter for subsystem before querying (authored by broulik). REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11290?vs=29416&id=29417

D11290: [UDevManager] Already filter for subsystem before querying

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #frameworks, davidedmundson Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

broulik updated this revision to Diff 29416. broulik edited the summary of this revision. broulik added a comment. - Check for usb subsystem also in queryDeviceInterface REPOSITORY R245 Solid CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11290?vs=29412&id=29416 REVISION DETAIL

D11290: [UDevManager] Already filter for subsystem before querying

broulik added a comment. In D11290#224807 , @davidedmundson wrote: > If you can prove that property is only valid for USB subsystems, then you can ship it, otherwise, no. From udev code https://github.com/systemd/systemd/blob/master/src

D11290: [UDevManager] Already filter for subsystem before querying

davidedmundson added a comment. Copying our IRC chat: I tried something /very very/ similar https://phabricator.kde.org/D8495?vs=on&id=21368&whitespace=ignore-most#toc which merges queryDeviceInterface into the earlier query. It didn't work. This patch is a bit different, it does

D11290: [UDevManager] Already filter for subsystem before querying

ngraham added a comment. Cool! Any chance we can add an autotest? Solid's code seems somewhat fragile, judging by the regressions that were accidentally introduced in https://cgit.kde.org/solid.git/commit/?id=1384f275ab2f1ad1841753ee163af6d1b0bb952b REPOSITORY R245 Solid REVISION DETAIL

D11290: [UDevManager] Already filter for subsystem before querying

broulik edited the summary of this revision. REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #frameworks, davidedmundson Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

broulik added a comment. It brings the number of sys calls from 28000 down to 860 here using the first grep command in the comment, could have helped somewhat I guess but the second command is completely bogus for me. needs further investigation. It does give a significant speedup which is a

D11290: [UDevManager] Already filter for subsystem before querying

ngraham added a comment. Any chance this fixes https://bugs.kde.org/show_bug.cgi?id=391738? REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D11290 To: broulik, #frameworks, davidedmundson Cc: ngraham, michaelh

D11290: [UDevManager] Already filter for subsystem before querying

broulik created this revision. broulik added reviewers: Frameworks, davidedmundson. Restricted Application added a project: Frameworks. broulik requested review of this revision. REVISION SUMMARY This does some rough filtering in advance before creating our wrapper items with properties and all