ngraham updated this revision to Diff 30226.
ngraham added a comment.
Always show top app inline, and others in the sub-menu
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11569?vs=30182=30226
BRANCH
open-with-usability (branched from master)
REVISION
ngraham added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in kfileitemactions.cpp:658
> This introduce one more so menu can grow with 6 items which is much. Why not
> keep same approach, but we can show every time the *preferred* one
>
> ---
> Open with
anthonyfieroni added inline comments.
INLINE COMMENTS
> kfileitemactions.cpp:658
> +} else {
> +menu ->addSection(i18n("Open With"));
> }
This introduce one more so menu can grow with 6 items which is much. Why not
keep same approach, but we can show
abetts added a comment.
Would it look good also that if there were less handlers and they are
presented in the same menu that it goes like this:
Open With
- Gwenview
- GIMP
I am talking about right justification instead of
Open With
Gwenview
GIMP
REPOSITORY
R241
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11569
To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: michaelh, ngraham
ngraham updated this revision to Diff 30182.
ngraham added a comment.
Use a header for 1-4 apps; it looks better and there's no redundant text
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D11569?vs=30181=30182
BRANCH
open-with-usability (branched from
ngraham added a comment.
Possible change: In the inline case where there are fewer than 5 apps, we
could use a header entitled "Open With" and then remove that text from all the
menu items, to prevent it from being duplicated up to 5 times.
REPOSITORY
R241 KIO
REVISION DETAIL
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D11569
To: ngraham, rkflx, #vdg, #frameworks, #dolphin
Cc: michaelh, ngraham
ngraham created this revision.
ngraham added reviewers: rkflx, VDG, Frameworks, Dolphin.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.
REVISION SUMMARY
This patch adjusts the Open With UI to improve the strings and display apps
inline (without a
