D11649: Fix crash in the file slave

2018-08-16 Thread Albert Astals Cid
aacid planned changes to this revision. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11649 To: aacid, #frameworks, dfaure Cc: kde-frameworks-devel, #kde_connect, michaelh, ngraham, bruns

D11649: Fix crash in the file slave

2018-03-29 Thread David Faure
dfaure added a comment. canResume is an "internal" signal, I don't think any apps can do anything meaningful with it, so I don't mind you connecting to it, except that I think this is the wrong layer... BTW did you notice the section about resuming in docs/design.txt? It might help

D11649: Fix crash in the file slave

2018-03-28 Thread Nicolas Fella
nicolasfella added a subscriber: KDE Connect. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11649 To: aacid, #frameworks, dfaure Cc: #kde_connect, michaelh, ngraham

D11649: Fix crash in the file slave

2018-03-24 Thread Albert Astals Cid
aacid created this revision. aacid added reviewers: Frameworks, dfaure. Restricted Application added a project: Frameworks. aacid requested review of this revision. REVISION SUMMARY When doing a KIO::storedPut to a filename that has a .part file existing there were two problems: - We were