D11733: Allow opening items from the open/save dialogs

ngraham abandoned this revision. ngraham added a comment. After thinking about this for a few weeks, I can't imagine and haven't seen a use case for using the Open File dialog to open the file in a different app that wouldn't be better served in another way. REPOSITORY R241 KIO REVISION D

D11733: Allow opening items from the open/save dialogs

ngraham added a comment. In D11733#236903 , @gregormi wrote: > I come from Windows where the Open item is also available. Not having it feels like a lack of flexibility. I think having it in the context menu will not affect the "normal" user. Y

D11733: Allow opening items from the open/save dialogs

gregormi added a comment. In D11733#235208 , @rkflx wrote: > and the bug reporter's use case of selecting a file in a web browser for upload essentially wants the existing [F11] preview feature and perhaps a better preview feature in the web app

D11733: Allow opening items from the open/save dialogs

ngraham added a comment. Yeah, I wasn't convinced either. One thing I realize is that when we turned on previews by default in Dolphin, we didn't do so in the open/save dialogs. So that might be low-hanging fruit to improve discoverability of file previews in those dialogs. REPOSITORY

D11733: Allow opening items from the open/save dialogs

rkflx added a comment. TBH I'm not convinced that's something which should be added. That's a pretty weird workflow in general, and the bug reporter's use case of selecting a file in a web browser for upload essentially wants the existing [F11] preview feature and perhaps a better preview fe

D11733: Allow opening items from the open/save dialogs

broulik added a comment. Shouldn't this be using the "Open With" menu? If I'm in the Open dialog for Kate and click "Open" for a text file, it will just open in a new Kate instance (rather than opening in the application the dialog belongs to as I would expect from naming) REPOSITORY R241

D11733: Allow opening items from the open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11733 To: ngraham, #dolphin, #frameworks Cc: michaelh, ngraham

D11733: Allow opening items from the open/save dialogs

ngraham created this revision. ngraham added reviewers: Dolphin, Frameworks. Restricted Application added a project: Frameworks. ngraham requested review of this revision. REVISION SUMMARY This patch adds an Open menu item to the open/save dialogs' context menu. FEATURE: 392329 TEST PLAN

D11733: Allow opening items from the open/save dialogs

ngraham edited the test plan for this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D11733 To: ngraham, #dolphin, #frameworks Cc: michaelh, ngraham