D12071: add a new ConstrainedSquare formfactor

kossebau added a comment. In D12071#243259 , @mart wrote: > suggests that is more about it being constrained both horizontally and vertically than being a square, which may not be a given (the actual name comes from an old enum value in Plasma

D12071: add a new ConstrainedSquare formfactor

apol added inline comments. INLINE COMMENTS > plasma.h:89 > for the desktop or the particular device. */ > +ConstrainedSquare /**When the applet is constrained both vertically > and horizontally, > + and can't grow in neither directions, such as

D12071: add a new ConstrainedSquare formfactor

mart added a comment. suggests that is more about it being constrained both horizontally and vertically than being a square, which may not be a given (the actual name comes from an old enum value in Plasma 4 that was AspectRatio) is i think the most correct name, even if less intuitive

D12071: add a new ConstrainedSquare formfactor

mart edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D12071 To: mart, #plasma Cc: kossebau, #frameworks, michaelh, ngraham, bruns

D12071: add a new ConstrainedSquare formfactor

kossebau added a comment. Commit message could see some "bug:388995" :) "ConstrainedSquare" sounds like there could be other "Contrained*" in the future? Why this term combination instead of just "Square"? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D12071: add a new ConstrainedSquare formfactor

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. mart requested review of this revision. REVISION SUMMARY It will make possible for applets to know they are in a systray-like