D12114: Revive 'Description' property for DublinCore metadata

[Alexander Stippich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R286:103f86746b8a: Revive Description property for 
DublinCore metadata (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12114?vs=45234=45607

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/samplefiles/test.odt
  src/extractors/dublincoreextractor.cpp
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

[Alexander Stippich]

astippich added a comment.


  I've reverted the test data for docx format for now, since there are 
apparently more issues. Funnily, LibreOffice and MS Word label the description 
property with "Comment".

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

[Alexander Stippich]

astippich updated this revision to Diff 45234.
astippich added a comment.


  - revert docx test data for now

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12114?vs=44834=45234

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/samplefiles/test.odt
  src/extractors/dublincoreextractor.cpp
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

[Alexander Stippich]

astippich added inline comments.

INLINE COMMENTS

> bruns wrote in office2007extractortest.cpp:52
> Strictly speaking, this should be part of another commit.
> Feel free to split it off and git push without review.

Just to let you know, I'm currently having issues creating a new test file. 
Saving with LibreOffice to .docx causes an incorrect mime type of the file, 
which is also reflected in this diff (see below). This seems to be a bug in 
LibreOffice. Looks like I have to use MS Word here.

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

[Stefan Brüns]

bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> office2007extractortest.cpp:52
>  QCOMPARE(result.properties().value(Property::Language), 
> QVariant(QStringLiteral("en-US")));
> +QCOMPARE(result.properties().value(Property::PageCount), QVariant(1));
> +QCOMPARE(result.properties().value(Property::WordCount), QVariant(4));

Strictly speaking, this should be part of another commit.
Feel free to split it off and git push without review.

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

[Alexander Stippich]

astippich updated this revision to Diff 44834.
astippich edited the summary of this revision.
astippich added a comment.


  - rebase on top of D16196 

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12114?vs=44833=44834

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/samplefiles/test.odt
  autotests/samplefiles/test_libreoffice.docx
  src/extractors/dublincoreextractor.cpp
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

[Alexander Stippich]

astippich added a dependency: D16196: add a description property to 
KFileMetaData.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

[Alexander Stippich]

astippich retitled this revision from "Revive 'Description' property" to 
"Revive 'Description' property for DublinCore metadata".
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property

[Alexander Stippich]

astippich updated this revision to Diff 44833.
astippich edited the summary of this revision.
astippich added a comment.


  - use description property for dublincore description

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12114?vs=31887=44833

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/samplefiles/test.odt
  autotests/samplefiles/test_libreoffice.docx
  src/extractors/dublincoreextractor.cpp
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp
  src/properties.h
  src/propertyinfo.cpp

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property

[Alexander Stippich]

astippich commandeered this revision.
astippich added a reviewer: michaelh.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, michaelh
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property

[Alexander Stippich]

astippich edited reviewers, added: bruns; removed: michaelh.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property

[Stefan Brüns]

bruns added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  @michaelh - are you still working on this?
  
  I think using Property::Description for dc::description and the like is very 
sensible, so I would welcome if you pushed this forward.
  
  Regarding the submission scheme, can you split this up into two distinct 
reviews, the first one adding autotests, covering the status quo as is, and the 
second one doing the transition from Propery::Comment to Property::Description

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: michaelh, #baloo, #frameworks
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham

D12114: Revive 'Description' property

[Michael Heidelbach]

michaelh planned changes to this revision.
michaelh added a comment.


  Create cross extractor test

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: michaelh, #baloo, #frameworks
Cc: bruns, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12114: Revive 'Description' property

[Michael Heidelbach]

michaelh created this revision.
michaelh added reviewers: Baloo, Frameworks.
Restricted Application added projects: Frameworks, Baloo.
michaelh requested review of this revision.

REVISION SUMMARY
  `Property::Description` did not make it into KF5, `Property::Comment` is used 
instead .
  This patch revives 'Description' as it is more specific and to avoid 
confusion.
  
  - Create tests for epub, odf and office documents
  - Ensure 'Comment' is no longer provided
  - Make tests pass

TEST PLAN
  make test

REPOSITORY
  R286 KFileMetaData

BRANCH
  desc_instead_comm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/epubextractortest.cpp
  autotests/epubextractortest.h
  autotests/odfextractortest.cpp
  autotests/odfextractortest.h
  autotests/office2007extractortest.cpp
  autotests/office2007extractortest.h
  autotests/samplefiles/test.epub
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp
  src/properties.h
  src/propertyinfo.cpp

To: michaelh, #baloo, #frameworks
Cc: ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, alexeymin