D12114: Revive 'Description' property for DublinCore metadata

2018-11-16 Thread Alexander Stippich 
This revision was automatically updated to reflect the committed changes.
Closed by commit R286:103f86746b8a: Revive Description property for 
DublinCore metadata (authored by astippich).

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12114?vs=45234=45607

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/samplefiles/test.odt
  src/extractors/dublincoreextractor.cpp
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

2018-11-10 Thread Alexander Stippich 
astippich added a comment.


  I've reverted the test data for docx format for now, since there are 
apparently more issues. Funnily, LibreOffice and MS Word label the description 
property with "Comment".

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

2018-11-10 Thread Alexander Stippich 
astippich updated this revision to Diff 45234.
astippich added a comment.


  - revert docx test data for now

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12114?vs=44834=45234

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/samplefiles/test.odt
  src/extractors/dublincoreextractor.cpp
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

2018-11-10 Thread Alexander Stippich 
astippich added inline comments.

INLINE COMMENTS

> bruns wrote in office2007extractortest.cpp:52
> Strictly speaking, this should be part of another commit.
> Feel free to split it off and git push without review.

Just to let you know, I'm currently having issues creating a new test file. 
Saving with LibreOffice to .docx causes an incorrect mime type of the file, 
which is also reflected in this diff (see below). This seems to be a bug in 
LibreOffice. Looks like I have to use MS Word here.

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

2018-11-04 Thread Stefan Brüns 
bruns accepted this revision.
bruns added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> office2007extractortest.cpp:52
>  QCOMPARE(result.properties().value(Property::Language), 
> QVariant(QStringLiteral("en-US")));
> +QCOMPARE(result.properties().value(Property::PageCount), QVariant(1));
> +QCOMPARE(result.properties().value(Property::WordCount), QVariant(4));

Strictly speaking, this should be part of another commit.
Feel free to split it off and git push without review.

REPOSITORY
  R286 KFileMetaData

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

2018-11-04 Thread Alexander Stippich 
astippich updated this revision to Diff 44834.
astippich edited the summary of this revision.
astippich added a comment.


  - rebase on top of D16196 

REPOSITORY
  R286 KFileMetaData

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12114?vs=44833=44834

BRANCH
  description_dc

REVISION DETAIL
  https://phabricator.kde.org/D12114

AFFECTED FILES
  autotests/epubextractortest.cpp
  autotests/odfextractortest.cpp
  autotests/office2007extractortest.cpp
  autotests/samplefiles/test.odt
  autotests/samplefiles/test_libreoffice.docx
  src/extractors/dublincoreextractor.cpp
  src/extractors/epubextractor.cpp
  src/extractors/odfextractor.cpp
  src/extractors/office2007extractor.cpp

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

2018-11-04 Thread Alexander Stippich 
astippich added a dependency: D16196: add a description property to 
KFileMetaData.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams

D12114: Revive 'Description' property for DublinCore metadata

2018-11-04 Thread Alexander Stippich 
astippich retitled this revision from "Revive 'Description' property" to 
"Revive 'Description' property for DublinCore metadata".
astippich edited the summary of this revision.

REPOSITORY
  R286 KFileMetaData

REVISION DETAIL
  https://phabricator.kde.org/D12114

To: astippich, #baloo, #frameworks, bruns
Cc: kde-frameworks-devel, bruns, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, abrahams