D12192: Decode more documentUrls

2018-04-15 Thread Michael Heidelbach
michaelh added a comment. In D12192#246449 , @bruns wrote: > Can you add a little bit more info to the commit message, e.g. an example how the output looks before and after? I don't know... I realized the necessity to

D12192: Decode more documentUrls

2018-04-15 Thread Michael Heidelbach
michaelh edited the summary of this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12192 To: michaelh, #baloo, bruns Cc: bruns, #frameworks, ashaposhnikov, michaelh, astippich, spoorun, ngraham, alexeymin

D12192: Decode more documentUrls

2018-04-14 Thread Stefan BrĂ¼ns
bruns requested changes to this revision. bruns added a comment. This revision now requires changes to proceed. Can you add a little bit more info to the commit message, e.g. an example how the output looks before and after? REPOSITORY R293 Baloo REVISION DETAIL

D12192: Decode more documentUrls

2018-04-14 Thread Michael Heidelbach
michaelh added inline comments. INLINE COMMENTS > transaction.cpp:469 > for (quint64 id: allIds) { > QByteArray url = docUrlDb.get(id); > if (url.isEmpty()) { For your convenience REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D12192 To:

D12192: Decode more documentUrls

2018-04-14 Thread Michael Heidelbach
michaelh created this revision. michaelh added a reviewer: Baloo. Restricted Application added projects: Frameworks, Baloo. Restricted Application added a subscriber: Frameworks. michaelh requested review of this revision. TEST PLAN make test REPOSITORY R293 Baloo BRANCH file-encoding