D12270: Create a public function to access the actionMenu

2018-05-10 Thread Nathaniel Graham 
ngraham abandoned this revision.
Restricted Application added a subscriber: kde-frameworks-devel.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12270

To: ngraham, #frameworks
Cc: kde-frameworks-devel, broulik, michaelh, ngraham, bruns

D12270: Create a public function to access the actionMenu

2018-04-17 Thread Nathaniel Graham 
ngraham added a comment.


  If you'd like, I can abandon the diff and WONTFIX the bug. I'm just trying to 
fix low-hanging fruit issues as I triage old KIO bugs.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12270

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham, bruns

D12270: Create a public function to access the actionMenu

2018-04-17 Thread Kai Uwe Broulik 
broulik added a comment.


  This bug is 15 years old and no proof to this claim was provided.
  Also, the wording as "subclasses can add" suggests a virtual method

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12270

To: ngraham, #frameworks
Cc: broulik, michaelh, ngraham, bruns

D12270: Create a public function to access the actionMenu

2018-04-16 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added a reviewer: Frameworks.
Restricted Application added a project: Frameworks.
ngraham requested review of this revision.

REVISION SUMMARY
  Create a public function to access the actionMenu, so clients and subclasses 
can manipulate it as they see fit.
  
  BUG: 83679
  FIXED-IN: 5.46

REPOSITORY
  R241 KIO

BRANCH
  public-actionmenu (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12270

AFFECTED FILES
  src/filewidgets/kdiroperator.cpp
  src/filewidgets/kdiroperator.h

To: ngraham, #frameworks
Cc: michaelh, ngraham, bruns