D12353: [API dox] New UI marker @item:valuesuffix

2018-04-28 Thread Friedrich W . H . Kossebau
This revision was automatically updated to reflect the committed changes. Closed by commit R249:b88bb7e1b8d9: [API dox] New UI marker @item:valuesuffix (authored by kossebau). REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12353?vs=32605=33261 REVISION DETAIL

D12353: [API dox] New UI marker @item:valuesuffix

2018-04-19 Thread Friedrich W . H . Kossebau
kossebau updated this revision to Diff 32605. kossebau added a comment. add also in kuit handling code REPOSITORY R249 KI18n CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12353?vs=32571=32605 BRANCH additemvaluesuffixuimaker REVISION DETAIL

D12353: [API dox] New UI marker @item:valuesuffix

2018-04-19 Thread Friedrich W . H . Kossebau
kossebau added a comment. In D12353#249996 , @aacid wrote: > All the other elements of that list have an entry like > > ./src/kuitmarkup.cpp:281:SET_CUE(InrangeCue, QStringLiteral("inrange")); > > Do we need that too for valuesuffix?

D12353: [API dox] New UI marker @item:valuesuffix

2018-04-19 Thread Albert Astals Cid
aacid added a comment. All the other elements of that list have an entry like ./src/kuitmarkup.cpp:281:SET_CUE(InrangeCue, QStringLiteral("inrange")); Do we need that too for valuesuffix? REPOSITORY R249 KI18n BRANCH additemvaluesuffixuimaker REVISION DETAIL

D12353: [API dox] New UI marker @item:valuesuffix

2018-04-19 Thread Friedrich W . H . Kossebau
kossebau added a comment. @ilic Thanks for the quick review :) Will keep this review request open until Sun. April 29th, to give translators more chance to tell any issue they might see. REPOSITORY R249 KI18n BRANCH additemvaluesuffixuimaker REVISION DETAIL

D12353: [API dox] New UI marker @item:valuesuffix

2018-04-19 Thread Chusslove Illich
ilic accepted this revision. This revision is now accepted and ready to land. REPOSITORY R249 KI18n BRANCH additemvaluesuffixuimaker REVISION DETAIL https://phabricator.kde.org/D12353 To: kossebau, #localization, ilic Cc: #frameworks, michaelh, bruns

D12353: [API dox] New UI marker @item:valuesuffix

2018-04-19 Thread Friedrich W . H . Kossebau
kossebau added a reviewer: ilic. REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12353 To: kossebau, #localization, ilic Cc: #frameworks, michaelh, bruns

D12353: [API dox] New UI marker @item:valuesuffix

2018-04-19 Thread Friedrich W . H . Kossebau
kossebau added a comment. See also ML thread https://marc.info/?t=15235477182=1=2 REPOSITORY R249 KI18n REVISION DETAIL https://phabricator.kde.org/D12353 To: kossebau, #localization Cc: #frameworks, michaelh, bruns

D12353: [API dox] New UI marker @item:valuesuffix

2018-04-19 Thread Friedrich W . H . Kossebau
kossebau created this revision. kossebau added a reviewer: Localization. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. kossebau requested review of this revision. REVISION SUMMARY Allows to mark strings which are used for