D12378: Properly search for NetworkManager

2019-05-28 Thread Rik Mills
Herald added a subscriber: kde-frameworks-devel.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D12378

To: jgrulich, #frameworks
Cc: kde-frameworks-devel, rikmills, #frameworks, michaelh, ngraham, bruns


D12378: Properly search for NetworkManager

2018-04-22 Thread Jan Grulich
jgrulich updated this revision to Diff 32836.
jgrulich edited the summary of this revision.
jgrulich added a comment.


  Do not use prefix for NM header and remove unnecessary workarounds

REPOSITORY
  R239 KDELibs4Support

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12378?vs=32641&id=32836

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12378

AFFECTED FILES
  cmake/modules/FindNetworkManager.cmake
  src/solid-networkstatus/kded/CMakeLists.txt
  src/solid-networkstatus/kded/networkmanagerstatus.cpp
  src/solid-networkstatus/kded/networkmanagerstatus.h

To: jgrulich, #frameworks
Cc: #frameworks, michaelh, bruns


D12378: Properly search for NetworkManager

2018-04-20 Thread Jan Grulich
jgrulich edited the summary of this revision.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D12378

To: jgrulich, #frameworks
Cc: #frameworks, michaelh, bruns


D12378: Properly search for NetworkManager

2018-04-20 Thread Jan Grulich
jgrulich edited the summary of this revision.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D12378

To: jgrulich, #frameworks
Cc: #frameworks, michaelh, bruns


D12378: Properly search for NetworkManager

2018-04-20 Thread Jan Grulich
jgrulich added a reviewer: Frameworks.

REPOSITORY
  R239 KDELibs4Support

REVISION DETAIL
  https://phabricator.kde.org/D12378

To: jgrulich, #frameworks
Cc: #frameworks, michaelh, bruns


D12378: Properly search for NetworkManager

2018-04-20 Thread Jan Grulich
jgrulich created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
jgrulich requested review of this revision.

REVISION SUMMARY
  Make use of CMake module from nm-qt to search for libnm (NetworkManager 
library) instead
  of previous NM library which has been deprecated. This new library has been 
introduced with
  NM 1.0 which was released ~3 years ago so I assume it's not problem to 
require it. It also 
  fixes build of solid-networkstatus with NM support as it was not never 
enabled because NM_07
  was not set.

REPOSITORY
  R239 KDELibs4Support

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12378

AFFECTED FILES
  cmake/modules/FindNetworkManager.cmake
  src/solid-networkstatus/kded/CMakeLists.txt
  src/solid-networkstatus/kded/networkmanagerstatus.cpp
  src/solid-networkstatus/kded/networkmanagerstatus.h

To: jgrulich
Cc: #frameworks, michaelh, bruns