D12477: Add unit test to see that :/ files can work

2019-02-02 Thread Friedrich W. H. Kossebau
kossebau added a comment. In D12477#403709 , @dfaure wrote: > Still, at the level of the KParts frameworks itself it's all fine ;) Which "level" do you mean here? This test only works by pure chance given the current implementation detail

D12477: Add unit test to see that :/ files can work

2019-02-02 Thread David Faure
dfaure added a comment. Right, this would fail if the part was not using QFile, indeed. Still, at the level of the KParts frameworks itself it's all fine ;) REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D12477 To: svuorela, dfaure, kossebau, #frameworks Cc: kde-fram

D12477: Add unit test to see that :/ files can work

2019-02-02 Thread David Faure
dfaure accepted this revision. This revision is now accepted and ready to land. Herald added a subscriber: kde-frameworks-devel. REPOSITORY R306 KParts REVISION DETAIL https://phabricator.kde.org/D12477 To: svuorela, dfaure, kossebau, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham,

D12477: Add unit test to see that :/ files can work

2018-04-23 Thread Friedrich W . H . Kossebau
kossebau added a comment. It passes only by pure chance as NotepadPart uses QFile, which understands such an url. So the value of that new autptest is questionable, as this is not testing any API promise. For `ReadOnlyPart::localFilePath()` it says: "Returns the local file path associat

D12477: Add unit test to see that :/ files can work

2018-04-23 Thread Sune Vuorela
svuorela created this revision. svuorela added reviewers: dfaure, kossebau, Frameworks. Restricted Application added a project: Frameworks. svuorela requested review of this revision. REVISION SUMMARY I wasn't sure if :/foo stuff would work, so I tried writing a unit test to help me. Let's subm