ntninja added a comment.
Thanks, I'll keep that in mind for next time.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D12709
To: ntninja, dfaure
Cc: dfaure, apol, kde-frameworks-devel, michaelh, ngraham, bruns
dfaure closed this revision.
dfaure added a comment.
https://commits.kde.org/frameworkintegration/4cc12a5ad1fa92f8b934f02ff2e401539ec9b9f7
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D12709
To: ntninja, dfaure
Cc: dfaure, apol,
dfaure added a comment.
Ah, you need to specify that you don't have a developer account, otherwise
the assumption is simply that you'll push the patch once approved.
I'll land it now.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D12709
To:
ntninja added a comment.
Since these changes have been approved and marked read-to-land for quite some
time, could this please be done soon? Thank you!
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D12709
To: ntninja, dfaure
Cc: dfaure, apol,
dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.
We have done similar things in other frameworks, to indeed make it easier to
reuse them in contexts where not all dependencies are wanted.
See SONNET_USE_WIDGETS,
tundracomp added a comment.
The target application I'm building has only very minimal dependencies on Qt
(just QtCore + QtWidgets + PyQt5) and no real dependencies on KDE. The
application only has a size footprint of about 6MiB, the required Qt libraries
use about 10MiB of space, the
apol added a comment.
If you are building a flatpak, please use org.kde.Sdk.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D12709
To: tundracomp
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
tundracomp added a comment.
I build a Qt app with „just enough“ KDE-integration for the Flatpak sandbox
where I have no use for this KPackage stuff. I know I could just include the
install handlers in the build and drop them afterwards, but that would require
a build KNS (and all of *its*
apol added a comment.
Why would we want to make it optional?
In fact, the only one that is mandatory is the KNS one.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D12709
To: tundracomp
Cc: apol, kde-frameworks-devel, michaelh, ngraham, bruns
tundracomp added a comment.
Restricted Application edited subscribers, added: kde-frameworks-devel;
removed: Frameworks.
Any review of this would be greatly apprechiated…
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D12709
To: tundracomp
Cc:
tundracomp created this revision.
tundracomp added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
tundracomp requested review of this revision.
REVISION SUMMARY
Currently building the KPackage install handlers is mandatory when building
the
11 matches
Mail list logo