D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Antonio Rojas
arojas abandoned this revision. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12761 To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux Cc: kde-frameworks-devel, kfm-devel, cgiboudeaux, ngraham, alexde, sourabhboss, feverfew, michaelh, spoorun, navarromorales,

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Andreas Sturmlechner
asturmlechner added a comment. In D12761#367223 , @arojas wrote: > @asturmlechner can you post that in a new review request? I'll abandon this one. Done, this is now in https://phabricator.kde.org/D17205 REPOSITORY R320 KIO Extras

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Antonio Rojas
arojas added a comment. @asturmlechner can you post that in a new review request? I'll abandon this one. REPOSITORY R320 KIO Extras REVISION DETAIL https://phabricator.kde.org/D12761 To: arojas, dfaure, rdieter, asturmlechner, cgiboudeaux Cc: kde-frameworks-devel, kfm-devel,

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Andreas Sturmlechner
asturmlechner added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:4 > Any solution is fine however, we now patched ours kdebase4-runtime package to > disable kio-nfs completely. Pick the solution you prefer. Thanks, your FindTIRPC works for me. This is what I came up

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > cgiboudeaux wrote in CMakeLists.txt:4 > I added the solution we use in openSUSE: https://paste.kde.org/pscug8tik Any solution is fine however, we now patched ours kdebase4-runtime package to disable kio-nfs completely. Pick the solution you

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Christophe Giboudeaux
cgiboudeaux added inline comments. INLINE COMMENTS > asturmlechner wrote in CMakeLists.txt:4 > Could you suggest an alternative? Gentoo shares a similarity with Arch there, > because otherwise libtirpc could collide with older versions of glibc. I added the solution we use in openSUSE:

D12761: Allow building kio-nfs against standalone libtirpc

2018-11-27 Thread Andreas Sturmlechner
asturmlechner added inline comments. Herald added projects: Dolphin, Frameworks. Herald added subscribers: kfm-devel, kde-frameworks-devel. INLINE COMMENTS > CMakeLists.txt:175 > + add_feature_info("NFS kioslave" RPC_H_DIR "The RPC library is needed to > build the NFS kioslave") > +