D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

2018-06-12 Thread Jaime Torres Amate
jtamate abandoned this revision. jtamate added a comment. More numbers: The patch reserves 67 buckets in the QHash table vs. 37 by default. In my test, pasing the content of https://www.boe.es/legislacion/documentos/ConstitucionCASTELLANO.pdf from Okular, the number of items in the cach

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

2018-06-09 Thread Jaime Torres Amate
jtamate added a comment. In D12897#276182 , @dhaumann wrote: > @mwolff To me this looks ok - do you see an issue with this? E.g. that KTextEditor will require much more memory for almost no gain? If there is a more constrained limit, this

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

2018-06-09 Thread Christoph Cullmann
cullmann added a comment. I wonder if that really makes sense, given not all blocks contain ranges at all and they not really correlate with the block size. Does that change really make it much faster or just shift the costs? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricat

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

2018-06-09 Thread Dominik Haumann
dhaumann added subscribers: mwolff, dhaumann. dhaumann added a comment. @mwolff To me this looks ok - do you see an issue with this? E.g. that KTextEditor will require much more memory for almost no gain? REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D12897 To:

D12897: Reserve space for the cachedLineForRanges Qhash (optimization)

2018-05-15 Thread Jaime Torres Amate
jtamate created this revision. jtamate added reviewers: Kate, Frameworks. Restricted Application added projects: Kate, Frameworks. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. jtamate requested review of this revision. REVISION SUMMARY Most of the time was spent