D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

2019-06-25 Thread Nathaniel Graham 
ngraham abandoned this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13082

To: ngraham, #frameworks, apol, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

2019-06-25 Thread Nathaniel Graham 
ngraham added a comment.


  Abandoning in favor of D13048 

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13082

To: ngraham, #frameworks, apol, dfaure
Cc: broulik, kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

2018-05-24 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13082

To: ngraham, #frameworks, apol, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

2018-05-24 Thread Nathaniel Graham 
ngraham added a comment.


  Hmm, you're right. I guess there's no way around that if we want custom icon 
support here...

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13082

To: ngraham, #frameworks, apol, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

2018-05-24 Thread Kai Uwe Broulik 
broulik added a reviewer: dfaure.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13082

To: ngraham, #frameworks, apol, dfaure
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

2018-05-24 Thread Kai Uwe Broulik 
broulik added a comment.


  Imho fine in principle, but:
  `QFileInfo` stats internally and `KDesktopFile` actually reads file contents. 
I don't see how you came to the conclusion this doesn't stat.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13082

To: ngraham, #frameworks, apol
Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

2018-05-23 Thread Nathaniel Graham 
ngraham added a dependent revision: D13083: Respect custom directory icons in 
iconNameForURL().

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13082

To: ngraham, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore

2018-05-23 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: Frameworks, apol.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This allows us to use them in KIO::iconNameForURL() to gain custom folder 
icon support without needing to `stat` anything.
  
  CCBUG: 356045

TEST PLAN
  - No visual regressions in Dolphin
  - No unit test regressions

REPOSITORY
  R241 KIO

BRANCH
  public-iconFromDesktopFile-and-iconFromDirectoryFile (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13082

AFFECTED FILES
  src/core/global.cpp
  src/core/global.h
  src/core/kfileitem.cpp

To: ngraham, #frameworks, apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns