D13083: Respect custom directory icons in iconNameForURL()

ngraham abandoned this revision. ngraham added a comment. Abandoning in favor of D13048 REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik, dfaure Cc: kde-frameworks-devel, LeGast00n, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

ngraham added a comment. So maybe we should go back to using `KFileItem` like I had clumsily tried to do in D13048 , and just ensure that we don't even try to go down this codepath for remote folders. Does that seem like a better approach? REVISION

D13083: Respect custom directory icons in iconNameForURL()

dfaure added a comment. Unlike KFileItem, this function does no caching. I hope you do caching at the layer above then... To skip this for NFS/SMB shares you need code like the one in KFileItemPrivate::isSlow(). REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham,

D13083: Respect custom directory icons in iconNameForURL()

ngraham marked an inline comment as done. REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

ngraham updated this revision to Diff 34816. ngraham added a comment. Re-add `url.isLocalFile()` check to the higher-level `if` statement CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13083?vs=34765=34816 BRANCH custom-icons (branched from master) REVISION DETAIL

D13083: Respect custom directory icons in iconNameForURL()

ngraham edited the summary of this revision. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

broulik added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik, dfaure Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13083: Respect custom directory icons in iconNameForURL()

broulik added a comment. This still has the issue of blocking if the contents is an unavailable nfs share of some sort. INLINE COMMENTS > global.cpp:377 > +// Check to see if the folder has a custom icon > +QString customIcon = iconFromDirectoryFile(url.toLocalFile()); > +

D13083: Respect custom directory icons in iconNameForURL()

ngraham edited the summary of this revision. ngraham set the repository for this revision to R241 KIO. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D13083

D13083: Respect custom directory icons in iconNameForURL()

ngraham added a dependency: D13082: Make iconFromDirectoryFile() and iconFromDesktopFile() public in KIOCore. REVISION DETAIL https://phabricator.kde.org/D13083 To: ngraham, #frameworks, apol, broulik

D13083: Respect custom directory icons in iconNameForURL()

ngraham created this revision. ngraham added reviewers: Frameworks, apol, broulik. ngraham requested review of this revision. REVISION SUMMARY With `iconFromDirectoryFile()` a public function thanks to D13082 , we can use it to get custom icons for folders