D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella updated this revision to Diff 37052. nicolasfella added a comment. - Rename to ShareFileItemAction REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=36578=37052 BRANCH fiap REVISION DETAIL https://phabricator.kde.org/D13124

D13124: [RFC] Add Share action to Dolphin context menu

apol added a comment. Looks good to me overall. Maybe it would make sense to call it ShareFileItemAction everywhere? "purpose" is an implementation detail here. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. @apol ping? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales,

D13124: [RFC] Add Share action to Dolphin context menu

elvisangelaccio added a comment. +1, thanks! REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. @apol As soon as we land this we have two ways of sharing with KDE Connect. Should we just remove the FileItemActionPlugin from KDE Connect? Are there more applications than Dolphin using FIAPs? REPOSITORY R495 Purpose Library REVISION DETAIL

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella marked 3 inline comments as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella updated this revision to Diff 36578. nicolasfella added a comment. Use JSON metadata and install in kf5/fileitemaction namespace REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=34934=36578 BRANCH fiap REVISION DETAIL

D13124: [RFC] Add Share action to Dolphin context menu

elvisangelaccio added inline comments. INLINE COMMENTS > nicolasfella wrote in CMakeLists.txt:12-13 > Sorry, I don't quite understand what I am supposed to do I recommend to use the `kcoreaddons_add_plugin` cmake macro. Something like this: kcoreaddons_add_plugin(purposefileitemaction

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added inline comments. INLINE COMMENTS > elvisangelaccio wrote in CMakeLists.txt:12-13 > Please consider using json metadata and installing the plugin into the > `kf5/kfileitemaction` namespace. Sorry, I don't quite understand what I am supposed to do REPOSITORY R495 Purpose

D13124: [RFC] Add Share action to Dolphin context menu

elvisangelaccio removed a reviewer: Dolphin. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol, elvisangelaccio Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun,

D13124: [RFC] Add Share action to Dolphin context menu

elvisangelaccio removed a reviewer: elvisangelaccio. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, apol Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun, navarromorales,

D13124: [RFC] Add Share action to Dolphin context menu

elvisangelaccio added inline comments. INLINE COMMENTS > CMakeLists.txt:12-13 > +) > +install(TARGETS purposefileitemaction DESTINATION ${PLUGIN_INSTALL_DIR}) > +install(FILES purposesendfile.desktop DESTINATION ${SERVICES_INSTALL_DIR}) Please consider using json metadata and installing the

D13124: [RFC] Add Share action to Dolphin context menu

markg added a comment. In D13124#272698 , @nicolasfella wrote: > Friendly ping? ? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: markg,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. Friendly ping? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: markg, broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. In D13124#269655 , @broulik wrote: > I like yours better, I can abandon mine if you want to finish this :) I would have abandoned mine because you were first, but fine with me :) REPOSITORY R495 Purpose

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella added a comment. In D13124#268906 , @broulik wrote: > Have you seen D12895 ? I looked for similar patches with the #dolphin tag, but I didn't see

D13124: [RFC] Add Share action to Dolphin context menu

broulik added a comment. Have you seen D12895 ? REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: broulik, kde-frameworks-devel, elvisangelaccio, ngraham, apol,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella updated this revision to Diff 34934. nicolasfella added a comment. - Set mimetype to */* if reported mimetype is empty REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13124?vs=34933=34934 BRANCH fiap REVISION DETAIL

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella marked an inline comment as done. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13124 To: nicolasfella, #dolphin, apol, elvisangelaccio Cc: kde-frameworks-devel, elvisangelaccio, ngraham, apol, kfm-devel, #dolphin, michaelh, spoorun,

D13124: [RFC] Add Share action to Dolphin context menu

nicolasfella updated this revision to Diff 34933. nicolasfella added a comment. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. Make it a FileItemActionPlugin REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE