D13215: Update sizes before generating frame svg background

zzag added a comment. In D13215#271983 , @broulik wrote: > Doesn't make a difference in Oxygen's rounded corners on panels but doesn't make it worse either. Could you please share a screenshot? I still don't know what's wrong with Oxygen

D13215: Update sizes before generating frame svg background

zzag added a comment. Answer to my inline question: updateSizes can be omitted (but I would prefer to leave it). Also, `maskFrame->enabledBorders = frame->enabledBorders;` above is redundant (maskFrame->enabledBorders is already equal to frame->enabledBorders; it if wasn't the case, then cac

D13215: Update sizes before generating frame svg background

abetts added a comment. +1 on this! Love it! REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: abetts, mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

zzag added inline comments. INLINE COMMENTS > framesvg.cpp:483 > > updateSizes(maskFrame); > } Should it be here? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: mart, aseigo, broulik,

D13215: Update sizes before generating frame svg background

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: mart, aseigo, broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

zzag updated this revision to Diff 35338. zzag added a comment. Code cleanup. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13215?vs=35336&id=35338 BRANCH fix-framesvg-contentrect REVISION DETAIL https://phabricator.kde.org/D13215

D13215: Update sizes before generating frame svg background

zzag updated this revision to Diff 35336. zzag added a comment. Do not ignore previous maskFrame's enabled borders. REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13215?vs=35191&id=35336 BRANCH fix-framesvg-contentrect REVISION DETAIL

D13215: Update sizes before generating frame svg background

zzag added a comment. I think I got it. FrameSVGPrivate::updateFrameData updates only `frame`, `maskFrame` is updated lazily in `alphaMask` method, but the alphaMask method ignores previous state of enabledBorders. So, we end up with using stale maskFrame. E.g. FrameSVGPrivat

D13215: Update sizes before generating frame svg background

zzag added a comment. In D13215#271994 , @zzag wrote: > In D13215#271983 , @broulik wrote: > > > +1 > > > > Doesn't make a difference in Oxygen's rounded corners on panels but doesn't make it wo

D13215: Update sizes before generating frame svg background

zzag added subscribers: aseigo, mart. zzag added a comment. In D13215#271983 , @broulik wrote: > +1 > > Doesn't make a difference in Oxygen's rounded corners on panels but doesn't make it worse either. Please also profile whether it causes an

D13215: Update sizes before generating frame svg background

broulik added a comment. +1 Doesn't make a difference in Oxygen's rounded corners on panels but doesn't make it worse either. Please also profile whether it causes any needless recalculations on Plasma startup REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabr

D13215: Update sizes before generating frame svg background

zzag added a reviewer: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma, #frameworks Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

zzag edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

zzag added a comment. @broulik I tested panels with Oxygen(with compositing on and off) and didn't see any problems. > (Quickly browsing the bug numbers suggests it does \o/) Not sure about that. All of those bugs are "Breeze-related". REPOSITORY R242 Plasma Framework (Library) R

D13215: Update sizes before generating frame svg background

zzag edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma Cc: broulik, kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

zzag added a comment. In D13215#270878 , @broulik wrote: > Wow. I wasted hours in FrameSvg trying to find this. Does this also fix the panel mask in non-composited mode, e.g. round corners with Oxygen? (Quickly browsing the bug numbers suggests

D13215: Update sizes before generating frame svg background

broulik added a comment. Wow. I wasted hours in FrameSvg trying to find this. Does this also fix the panel mask in non-composited mode, e.g. round corners with Oxygen? (Quickly browsing the bug numbers suggests it does \o/) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL http

D13215: Update sizes before generating frame svg background

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

zzag edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13215 To: zzag, #plasma Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13215: Update sizes before generating frame svg background

zzag created this revision. zzag added a reviewer: Plasma. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. zzag requested review of this revision. REVISION SUMMARY In some cases, when rendering frame svg background, measures &