D13222: Use QDateTime for interfacing with QML

2018-06-04 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R242:d15f0fa8322d: Use QDateTime for interfacing with QML (authored by fvogt). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13222?vs=35217&id=35509

D13222: Use QDateTime for interfacing with QML

2018-06-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH master REVISION DETAIL https://phabricator.kde.org/D13222 To: fvogt, #plasma, #frameworks, davidedmundson Cc: ngraham, Zren, sharvey, kde-frameworks-de

D13222: Use QDateTime for interfacing with QML

2018-06-03 Thread Fabian Vogt
fvogt added a comment. In D13222#273334 , @ngraham wrote: > If the behavior changed in Qt 5.11, does the new code need a Qt version check, or is the patch backwards-compatible with earlier Qt versions? The latter, as it says in the test p

D13222: Use QDateTime for interfacing with QML

2018-06-03 Thread Nathaniel Graham
ngraham added a comment. If the behavior changed in Qt 5.11, does the new code need a Qt version check, or is the patch backwards-compatible with earlier Qt versions? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D13222 To: fvogt, #plasma, #frame

D13222: Use QDateTime for interfacing with QML

2018-05-30 Thread Fabian Vogt
fvogt created this revision. fvogt added reviewers: Plasma, Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. fvogt requested review of this revision. REVISION SUMMARY QDate from/to JS Date has unexpected results, so