D13268: Add signal for devices's address changing

[David Rosca]

drosca added a comment.


  Do you have a dev account?

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[Andrey Semenov]

andreysemenov added a comment.


  In D13268#273515 , @drosca wrote:
  
  > Do you have a dev account?
  
  
  I think i don't.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[Andrey Semenov]

andreysemenov added a comment.


  In D13268#273519 , @drosca wrote:
  
  > In D13268#273516 , 
@andreysemenov wrote:
  >
  > > In D13268#273515 , @drosca 
wrote:
  > >
  > > > Do you have a dev account?
  > >
  > >
  > > I think i don't.
  >
  >
  > Ok, your name and e-mail please so I can commit it for you.
  
  
  Andrey Semenov blizk...@gmail.com

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[David Rosca]

drosca added a comment.


  In D13268#273516 , @andreysemenov 
wrote:
  
  > In D13268#273515 , @drosca wrote:
  >
  > > Do you have a dev account?
  >
  >
  > I think i don't.
  
  
  Ok, your name and e-mail please so I can commit it for you.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R269:41b41939c028: Add signal for devicess address 
changing (authored by andreysemenov, committed by drosca).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D13268?vs=35331=35511#toc

REPOSITORY
  R269 BluezQt

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13268?vs=35331=35511

REVISION DETAIL
  https://phabricator.kde.org/D13268

AFFECTED FILES
  src/device.h
  src/device_p.cpp
  src/device_p.h

To: andreysemenov, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[Andrey Semenov]

andreysemenov removed a reviewer: mlaurent.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, drosca, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[David Rosca]

drosca accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, mlaurent, drosca
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[Andrey Semenov]

andreysemenov added a reviewer: mlaurent.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

To: andreysemenov, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13268: Add signal for devices's address changing

[Andrey Semenov]

andreysemenov created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
andreysemenov requested review of this revision.

REVISION SUMMARY
  If device connected with adapter via Bluetooth LE and i try to pair, device's 
address changing to another and it's address type becomes to 'public' instead 
of 'random'. So there is no actual  possibility to control pairing result.

TEST PLAN
  1. Create Bluetooth Low Energy service.
  2. Connect with device to this service.
  3. Try to pair device with BluezQt API.
  4. Even if device paired BluezQt API's method isPaired() returns false, 
because device changed its address and address type.
  5. Apply patch.
  6. Do same steps with connection to addressChanged signal.

REPOSITORY
  R269 BluezQt

REVISION DETAIL
  https://phabricator.kde.org/D13268

AFFECTED FILES
  src/device.h
  src/device_p.cpp
  src/device_p.h

To: andreysemenov
Cc: kde-frameworks-devel, michaelh, ngraham, bruns