D13365: BUG:391518 Fixed the cursor(caret) width in kate

2018-06-05 Thread Sven Brauch
brauch added a comment. Good find (annoyed me too) and sounds plausible to me. Thanks! Just one thing, do you call setRenderHint() inside the save() / restore() pair of the painter so the previous state is restored after drawing the caret? REPOSITORY R39 KTextEditor REVISION DETAIL

D13365: BUG:391518 Fixed the cursor(caret) width in kate

2018-06-05 Thread Aleix Pol Gonzalez
apol edited the summary of this revision. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor Cc: ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, bruns, demsking, cullmann, sars, dhaumann

D13365: BUG:391518 Fixed the cursor(caret) width in kate

2018-06-05 Thread Shubham
shubham added a comment. This patch will fix the Bug:391518 REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D13365: BUG:391518 Fixed the cursor(caret) width in kate

2018-06-05 Thread Sven Brauch
brauch added a comment. Good find (annoyed me too) and sounds plausible to me. Thanks! Just one thing, do you call setRenderHint() inside the save() / restore() pair of the painter so the previous state is restored after drawing the caret? REPOSITORY R39 KTextEditor REVISION DETAIL

D13365: BUG:391518 Fixed the cursor(caret) width in kate

2018-06-05 Thread Shubham
shubham added a reviewer: KTextEditor. REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham, #ktexteditor Cc: kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, ngraham, bruns, demsking, cullmann, sars, dhaumann

D13365: BUG:391518 Fixed the cursor(caret) width in kate

2018-06-05 Thread Shubham
shubham added a comment. In D13365#274370 , @brauch wrote: > Good find (annoyed me too) and sounds plausible to me. Thanks! > > Just one thing, do you call setRenderHint() inside the save() / restore() pair of the painter so the previous

D13365: BUG:391518 Fixed the cursor(caret) width in kate

2018-06-05 Thread Shubham
shubham created this revision. shubham created this object with visibility "All Users". shubham added a project: Kate. Restricted Application added subscribers: kde-frameworks-devel, kwrite-devel. Restricted Application added a project: Frameworks. shubham requested review of this revision.

D13365: BUG:391518 Fixed the cursor(caret) width in kate

2018-06-05 Thread Nathaniel Graham
ngraham added a comment. Please edit the Summary section to put `BUG: 391518` on its own line. See https://community.kde.org/Infrastructure/Phabricator#Add_special_keywords Thanks! REPOSITORY R39 KTextEditor REVISION DETAIL https://phabricator.kde.org/D13365 To: shubham,