D13365: Fixed the cursor(caret) width in kate

[Milian Wolff]

mwolff added a comment.


  @shubham looks like you are a victim of 
https://www.kalzumeus.com/2010/06/17/falsehoods-programmers-believe-about-names/
 right? :D

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: mwolff, cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, 
michaelh, kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  Thank you Brauch for committing it on my behalf.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

This revision was automatically updated to reflect the committed changes.
Closed by commit R39:e6f87dd57008: Fix caret width (authored by shubham, 
committed by brauch).

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13365?vs=35683&id=35735

REVISION DETAIL
  https://phabricator.kde.org/D13365

AFFECTED FILES
  src/render/katerenderer.cpp

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  In D13365#275130 , @brauch wrote:
  
  > I'm sorry I am so annoying, but iirc KDE's commit hooks will not accept 
commits with only one name fragment. Something equivalent to the western 
first/last name pair is required.
  
  
  Brauch officially my Full name is "Shubham", but if KDEs commit hooks dont 
accept it and you insist ,then my name is "Shubham Jangra"

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch added a comment.


  I'm sorry I am so annoying, but iirc KDE's commit hooks will not accept 
commits with only one name fragment. Something equivalent to the western 
first/last name pair is required.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  In D13365#274965 , @brauch wrote:
  
  > To submit the change with your name on it, I'd need a full name and email 
address, can you provide that? Thanks!
  
  
  Name: Shubham
  Mail: aryan100jan...@gmail.com

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch added a comment.


  To submit the change with your name on it, I'd need a full name and email 
address, can you provide that? Thanks!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch added a comment.


  Yes that looks better, I'll submit it later today.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham updated this revision to Diff 35683.
shubham added a comment.


  I believe this is the final patch.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13365?vs=35643&id=35683

REVISION DETAIL
  https://phabricator.kde.org/D13365

AFFECTED FILES
  src/render/katerenderer.cpp

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  Thank you Brauch for your quick reply.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch added a comment.


  Click "download raw diff" at the top-right of the page. This is the diff you 
uploaded. This is not the change we want to apply when merging this review 
request; it only contains the changes you did from your earlier version to the 
latest one, not the set of changes which needs to be applied to the repository. 
If you try to apply this patch to ktexteditor master, you will see that it 
fails.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  
  
  In D13365#274589 , @brauch wrote:
  
  > The change is good now but you screwed up the patch: you need to submit the 
full set of changes you want to do as a patch, not only the last iteration. Can 
you fix that? Thank you!
  
  
  Brauch,I didnt get you, can  you please elaborate?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  In D13365#274460 , @cullmann wrote:
  
  > Yep, looks nice!
  
  
  Thank you for accepting the patch.

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch added a comment.


  The change is good now but you screwed up the patch: you need to submit the 
full set of changes you want to do as a patch, not only the last iteration. Can 
you fix that? Thank you!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham added a comment.


  In D13365#274453 , @brauch wrote:
  
  > Yep, with that, it looks good to me. Do you have commit access?
  
  
  Thank you for committing it on my behalf

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Christoph Cullmann]

cullmann accepted this revision.
cullmann added a comment.


  Yep, looks nice!

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch, cullmann
Cc: cullmann, ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, 
kevinapavew, bruns, demsking, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Sven Brauch]

brauch accepted this revision.
brauch added a comment.
This revision is now accepted and ready to land.


  Yep, with that, it looks good to me. Do you have commit access?

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor, brauch
Cc: ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
bruns, demsking, cullmann, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham updated this revision to Diff 35643.
shubham added a comment.


  In this updated diff, setRenderHint() is called in between the pair of save() 
and restore() functions so as to save painter's previous state and achieve 
better painting quality.

REPOSITORY
  R39 KTextEditor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13365?vs=35634&id=35643

REVISION DETAIL
  https://phabricator.kde.org/D13365

AFFECTED FILES
  src/render/katerenderer.cpp

To: shubham, #ktexteditor
Cc: ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
bruns, demsking, cullmann, sars, dhaumann

D13365: Fixed the cursor(caret) width in kate

[Shubham]

shubham retitled this revision from "BUG:391518 Fixed the cursor(caret) width 
in kate" to "Fixed the cursor(caret) width in kate".

REPOSITORY
  R39 KTextEditor

REVISION DETAIL
  https://phabricator.kde.org/D13365

To: shubham, #ktexteditor
Cc: ngraham, brauch, kwrite-devel, kde-frameworks-devel, michaelh, kevinapavew, 
bruns, demsking, cullmann, sars, dhaumann