D13541: Port solid from Qt5::Widgets to Qt5::Gui

apol added a comment. In D13541#578027 , @bcooksley wrote: > This broke the build on FreeBSD - Please see https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/ fixed REPOSITORY R245 Solid REVISION DETAIL

D13541: Port solid from Qt5::Widgets to Qt5::Gui

bcooksley added a comment. This broke the build on FreeBSD - Please see https://build.kde.org/job/Frameworks/job/solid/job/kf5-qt5%20FreeBSDQt5.13/43/ REPOSITORY R245 Solid REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc:

D13541: Port solid from Qt5::Widgets to Qt5::Gui

This revision was automatically updated to reflect the committed changes. Closed by commit R245:9f868681b26e: Port solid from Qt5::Widgets to Qt5::Gui (authored by graesslin, committed by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13541?vs=36167=71569#toc REPOSITORY R245

D13541: Port solid from Qt5::Widgets to Qt5::Gui

davidedmundson added a comment. do it REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: davidedmundson, dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh, ngraham,

D13541: Port solid from Qt5::Widgets to Qt5::Gui

apol added a comment. I see this patch still works and applies. I'd say landing it would still make sense. If nobody disagrees I'll do so in a week. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks,

D13541: Port solid from Qt5::Widgets to Qt5::Gui

dhaumann added a comment. @graesslin pong? One year passed. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: dhaumann, kde-frameworks-devel, LeGast00n, GB_2, michaelh,

D13541: Port solid from Qt5::Widgets to Qt5::Gui

dhaumann added a comment. @graesslin ping REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

broulik accepted this revision. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol, broulik Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

apol accepted this revision. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To: graesslin, #frameworks, dhaumann, apol Cc: dhaumann, kde-frameworks-devel, michaelh, ngraham, bruns

D13541: Port solid from Qt5::Widgets to Qt5::Gui

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. const auto would be even nicer, if possible. Besides that, lgtm. REPOSITORY R245 Solid BRANCH gui-instead-of-widgets REVISION DETAIL https://phabricator.kde.org/D13541 To:

D13541: Port solid from Qt5::Widgets to Qt5::Gui

graesslin created this revision. graesslin added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. graesslin requested review of this revision. REVISION SUMMARY The only usage of widgets was to get the