D13583: KFormat: Allow usage of quantities beyond bytes and seconds

safaalfulaij added a comment. > Yes. As you said, these are symbols. For the names there may be transliterations, the symbols stay the same, to avoid ambiguities. This also matches my experience with datasheets, the text may be chinese, but measurements are given in SI units. I just

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. No problem @siddharthasahu. For the issue you're having with bindings i'd suggest raising a separate thread about that on kde-frameworks-devel as others might have missed it buried in this review. REPOSITORY R244 KCoreAddons REVISION DETAIL

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

siddharthasahu added a comment. Thank you for the clarification @bcooksley. I wonder if there is a way to enforce compilation of certain parts single threaded in make. Or some other way to ensure testing these components. But in any case, the builds are still failing for me. I hope

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. In regards to Python, that is not enabled as the bindings generation is not reliable and can easily fail on a highly parallel system (which the CI is, depending on the node it could be a Hexa Core with HT, so run using make -j13) The generation also had a nasty

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a comment. In D13583#292480 , @siddharthasahu wrote: > Hi. This commit seems to have introduced a build failure when the optional component PythonModuleGeneration is enabled: https://paste.kde.org/pvh0kutbq/5jo1sl

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a dependent revision: D14135: KFormat: fix typo in SI prefix name enum. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: siddharthasahu, bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

siddharthasahu added a comment. Hi. This commit seems to have introduced a build failure when the optional component PythonModuleGeneration is enabled: https://paste.kde.org/pvh0kutbq/5jo1sl On a related note, the CI does not have that component enables, which means it is not getting

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns removed a dependent revision: D14121: KFormat: Add unit tests for mili/micro SI prefixes. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

kossebau added a comment. In D13583#292115 , @bcooksley wrote: > You can add #windows to a review, however there still needs to be a degree of responsibility by those who are actually making commits

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a dependent revision: D14121: KFormat: Add unit tests for mili/micro SI prefixes. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: bcooksley, kossebau, kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a comment. This outputs 'µ' twice, so QChar(0xB5) should be equivalent: qWarning() << QString(QChar(0xB5)) << QString(QChar(u'µ')); REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: bcooksley, kossebau,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. You can add #windows to a review, however there still needs to be a degree of responsibility by those who are actually making commits to projects (especially in the case of #Frameworks

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

kossebau added a comment. Is there some tag which can be used to pull the people in who want to support that Closed Source Microsoft platform in such cases? I wasted some time of my FLOSS life meanwhile and found

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. Unfortunately we cannot leave it in a broken condition. Could we try encoding it differently perhaps? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: bcooksley, kossebau,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a comment. In D13583#292049 , @bcooksley wrote: > Sorry, but MSVC doesn't like this. > Please see https://build.kde.org/view/Frameworks/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/ MSVC seems to be broken,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bcooksley added a comment. Sorry, but MSVC doesn't like this. Please see https://build.kde.org/view/Frameworks/job/Frameworks%20kcoreaddons%20kf5-qt5%20WindowsMSVCQt5.10/ REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a comment. In D13583#291895 , @kossebau wrote: > @bruns Please update all the "@since" to 5.49, as this will be only part of the next KF version now. Sorry, updated and pushed REPOSITORY R244 KCoreAddons REVISION DETAIL

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

kossebau added a comment. @bruns Please update all the "@since" to 5.49, as this will be only part of the next KF version now. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks, astippich Cc: kossebau, kde-frameworks-devel, astippich,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

This revision was automatically updated to reflect the committed changes. Closed by commit R244:45dee45c8922: KFormat: Allow usage of quantities beyond bytes and seconds (authored by bruns). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D13583?vs=36735=37746#toc REPOSITORY R244

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

astippich accepted this revision. astippich added a comment. This revision is now accepted and ready to land. working fine here, but someone more qualified should have a look at the code REPOSITORY R244 KCoreAddons BRANCH d13583 REVISION DETAIL https://phabricator.kde.org/D13583 To:

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns updated this revision to Diff 36735. bruns marked an inline comment as done. bruns added a comment. added @since 5.48 tags use @code/@endcode add KFormat::Unit::Hertz remaining comments REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns marked 10 inline comments as done. bruns added inline comments. INLINE COMMENTS > kossebau wrote in kformatprivate.cpp:138-145 > Are we sure those unit symbols do not need to be localized? What about > languages using different scripts (cyrillic, chinese, arabic, etc)? Yes. As you said,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

astippich added a comment. Unfortunately it does not apply here because the base commit cannot be found. Also, may I already add an request? It would be great if the unit Hertz is included since it is used in baloo-widgets REPOSITORY R244 KCoreAddons REVISION DETAIL

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

kossebau added a comment. Some quick feedback, though no in-detail review myself for now, not sure I will be able later, so needs others as well. INLINE COMMENTS > kformat.h:117 > + * @see formatValue > + */ > +enum class Unit { Please add missing "@since 5.48" (as last item,

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a task: T8500: Add HIG rules about use of units/symbols in (config) UI. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks Cc: kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns added a dependent revision: D13584: KFormat: Replace byte specific implementation with generic one. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13583 To: bruns, #frameworks Cc: kde-frameworks-devel, astippich, michaelh, ngraham, bruns

D13583: KFormat: Allow usage of quantities beyond bytes and seconds

bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY Its useful to allow automatic formatting of quantities