D13584: KFormat: Replace byte specific implementation with generic one

2018-08-09 Thread Safa Alfulaij
safaalfulaij added a comment. Can we please take a look at this before continuing here? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13584 To: bruns, #frameworks Cc: safaalfulaij, dfaure, astippich,

D13584: KFormat: Replace byte specific implementation with generic one

2018-08-08 Thread David Faure
dfaure added a comment. I don't really know this code, but one thing that could be done to ensure that the change is safe, is to increase unittest coverage (which is already not too bad, but more would be safer)

D13584: KFormat: Replace byte specific implementation with generic one

2018-08-07 Thread Alexander Stippich
astippich added a comment. I've been running with it for a while and found no issues, but only giving +1 this time because of the fallout from the other patch (which I didn't catch, so others should have a look) REPOSITORY R244 KCoreAddons REVISION DETAIL

D13584: KFormat: Replace byte specific implementation with generic one

2018-07-14 Thread Stefan Brüns
bruns updated this revision to Diff 37748. bruns added a comment. Rebase REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13584?vs=36259=37748 BRANCH D13584 REVISION DETAIL https://phabricator.kde.org/D13584 AFFECTED FILES

D13584: KFormat: Replace byte specific implementation with generic one

2018-06-17 Thread Stefan Brüns
bruns added a task: T8500: Add HIG rules about use of units/symbols in (config) UI. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13584 To: bruns, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13584: KFormat: Replace byte specific implementation with generic one

2018-06-17 Thread Stefan Brüns
bruns added a dependency: D13583: KFormat: Allow usage of quantities beyond bytes and seconds. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D13584 To: bruns, #frameworks Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13584: KFormat: Replace byte specific implementation with generic one

2018-06-17 Thread Stefan Brüns
bruns created this revision. bruns added a reviewer: Frameworks. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: kde-frameworks-devel. bruns requested review of this revision. REVISION SUMMARY There is no need for duplicate implementations. As