D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

[Pino Toscano]

pino added a comment.


  In D13585#279400 , @asturmlechner 
wrote:
  
  > The problem with that is cmake picking the wrong dir (first in order is 
`lib`, while it should be e.g. `lib64`).
  
  
  Sure, and that's why I suggested to drop the usage of `LMDB_DIR`. There is 
already `CMAKE_PREFIX_PATH` 
 to 
specify additional prefixes where to search for installed software, so 
`LMDB_DIR` is simply an ad-hoc version of it.
  In case this is the chosen way, make sure to port away from where `LMDB_DIR` 
is used: https://lxr.kde.org/search?_filestring=&_string=LMDB_DIR

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: pino, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

[Andreas Sturmlechner]

asturmlechner added a comment.


  The problem with that is cmake picking the wrong dir (first in order is 
`lib`, while it should be e.g. `lib64`).

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: pino, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

[Pino Toscano]

pino added a comment.


  Or just drop the two `HINTS` (for `find_path` and `find_library`) altogether, 
as cmake already looks in standard include/library paths.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: pino, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, 
spoorun, ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

[Andreas Sturmlechner]

asturmlechner added a comment.


  Not convinved it is the best way but it is some way to make it point to the 
desired multiarch libdir rather than make it choose a random one.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

[Andreas Sturmlechner]

asturmlechner added a reviewer: Baloo.

REPOSITORY
  R293 Baloo

REVISION DETAIL
  https://phabricator.kde.org/D13585

To: asturmlechner, #baloo
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams

D13585: Use LIB_SUFFIX for lmdb libdir rather than hardcode lib

[Andreas Sturmlechner]

asturmlechner created this revision.
Restricted Application added projects: Frameworks, Baloo.
Restricted Application added subscribers: Baloo, kde-frameworks-devel.
asturmlechner requested review of this revision.

REPOSITORY
  R293 Baloo

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D13585

AFFECTED FILES
  cmake/FindLMDB.cmake

To: asturmlechner
Cc: kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, 
ngraham, bruns, abrahams