This revision was automatically updated to reflect the committed changes.
Closed by commit R235:ebb9d8d9c1a9: Add provider auto test (authored by
habacker).
REPOSITORY
R235 Attica
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13733?vs=36693&id=36743
REVISION DETAIL
https://phabri
leinir accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R235 Attica
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D13733
To: habacker, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
habacker marked an inline comment as done.
REPOSITORY
R235 Attica
REVISION DETAIL
https://phabricator.kde.org/D13733
To: habacker, leinir
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
habacker updated this revision to Diff 36693.
habacker added a comment.
- add documentation tp Provider::requestConfig()
REPOSITORY
R235 Attica
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D13733?vs=36668&id=36693
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D1
leinir requested changes to this revision.
leinir added a comment.
This revision now requires changes to proceed.
Autotests are good, but so is documentation - in principle this is good, but
new public functions without documentation isn't really acceptable :)
Apart from that, though, looks
habacker created this revision.
habacker added a reviewer: leinir.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
habacker requested review of this revision.
REVISION SUMMARY
The provider is checked by fetching the server conf
