D13773: [KDirOperator] Use alternating background colors for list-style views

2018-07-16 Thread Nathaniel Graham 
ngraham updated this revision to Diff 37920.
ngraham added a comment.


  Only use the alternating row colors for multi-column views, to avoid having 
it on any vertical sidebar-style lists

REPOSITORY
  R241 KIO

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D13773?vs=36806&id=37920

BRANCH
  alternating-row-colors-for-list-style-views (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13773

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: ngraham, #frameworks, #vdg, #dolphin
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

2018-07-16 Thread Andres Betts 
abetts added a comment.


  +1

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13773

To: ngraham, #frameworks, #vdg, #dolphin
Cc: abetts, kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

2018-07-16 Thread Nathaniel Graham 
ngraham added a comment.


  Ping?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13773

To: ngraham, #frameworks, #vdg, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

2018-06-28 Thread Nathaniel Graham 
ngraham edited the summary of this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13773

To: ngraham, #frameworks, #vdg, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

2018-06-27 Thread Nathaniel Graham 
ngraham edited the test plan for this revision.

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D13773

To: ngraham, #frameworks, #vdg, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D13773: [KDirOperator] Use alternating background colors for list-style views

2018-06-27 Thread Nathaniel Graham 
ngraham created this revision.
ngraham added reviewers: Frameworks, VDG, Dolphin.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This makes `KDirOperator` vilews match Dolphin, which uses the alternating 
style for listy views.

TEST PLAN
  Open dialog:
  
  Embedded filesystem browser in Kate

REPOSITORY
  R241 KIO

BRANCH
  alternating-row-colors-for-list-style-views (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D13773

AFFECTED FILES
  src/filewidgets/kdiroperatordetailview.cpp

To: ngraham, #frameworks, #vdg, #dolphin
Cc: kde-frameworks-devel, michaelh, ngraham, bruns