This revision was automatically updated to reflect the committed changes.
bruns marked an inline comment as done.
Closed by commit R244:b95bfd7e47a3: KFormat: Add unit tests for mili/micro SI
prefixes (authored by bruns).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
bruns marked an inline comment as done.
bruns added inline comments.
INLINE COMMENTS
> astippich wrote in kformattest.cpp:118
> typo: KFormat::UnitPrefix::Mil_l_i . Should be safe to change it since it
> hasn't been released in its current state, isn't it?
see D14135
bruns edited dependencies, added: D14135: KFormat: fix typo in SI prefix name
enum; removed: D13583: KFormat: Allow usage of quantities beyond bytes and
seconds.
REPOSITORY
R244 KCoreAddons
BRANCH
test1
REVISION DETAIL
https://phabricator.kde.org/D14121
To: bruns, #frameworks,
bruns updated this revision to Diff 37808.
bruns added a comment.
update after typo fix
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D14121?vs=37775=37808
BRANCH
test1
REVISION DETAIL
https://phabricator.kde.org/D14121
AFFECTED FILES
astippich accepted this revision.
astippich added a comment.
This revision is now accepted and ready to land.
test itself is fine, but I spotted a typo.
INLINE COMMENTS
> kformattest.cpp:118
> +
> +QCOMPARE(format.formatValue(0.010, KFormat::Unit::Meter, 1,
> KFormat::UnitPrefix::Mili,
bruns added a dependent revision: D14122: KFormat: Replace unicode literal with
unicode codepoint to fix MSVC build.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D14121
To: bruns, #frameworks, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
bruns added a dependency: D13583: KFormat: Allow usage of quantities beyond
bytes and seconds.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D14121
To: bruns, #frameworks, kossebau
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
bruns created this revision.
bruns added reviewers: Frameworks, kossebau.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
bruns requested review of this revision.
REVISION SUMMARY
Add test cases for KFormat::formatValue(...)
