D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Peter Mühlenpfordt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R237:f651a817ab00: Set system default shortcut Ctrl+0 for 
Actual Size action (authored by muhlenpfordt).

REPOSITORY
  R237 KConfig

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D14201?vs=38004=39450

REVISION DETAIL
  https://phabricator.kde.org/D14201

AFFECTED FILES
  src/gui/kstandardshortcut.cpp

To: muhlenpfordt, dfaure, broulik, ngraham, rkflx
Cc: jriddell, rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Peter Mühlenpfordt]

muhlenpfordt edited the summary of this revision.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham, rkflx
Cc: jriddell, rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.


  @muhlenpfordt I'd say go ahead with landing (after updating the version). It 
would be good to still have some testing time before the next Frameworks 
release.
  
  (The new Neon seems to be just around the corner, AFAICS.)

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham, rkflx
Cc: jriddell, rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Nathaniel Graham]

ngraham added a subscriber: jriddell.
ngraham added a comment.


  In D14201#303336 , @muhlenpfordt 
wrote:
  
  > The destination is still KDE Neon with Ubuntu 18.04? Is there any schedule 
for this?
  
  
  As far as I know, the latest status is available at 
https://jriddell.org/2018/07/26/kde-neon-bionic-update/, but maybe @jriddell 
can provide an update.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: jriddell, rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Peter Mühlenpfordt]

muhlenpfordt added a comment.


  The destination is still KDE Neon with Ubuntu 18.04? Is there any schedule 
for this?

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Nathaniel Graham]

ngraham added a comment.


  5.49 has been tagged, so this is now going into 5.50.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[David Faure]

dfaure accepted this revision.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Nathaniel Graham]

ngraham edited the summary of this revision.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Nathaniel Graham]

ngraham added a comment.


  Hah! Well in that case, that won't be a blocker.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Henrik Fehlauer]

rkflx added a comment.


  Thanks for your support ;)
  
  In D14201#296520 , @ngraham wrote:
  
  > Let's hold off on landing this patch (if accepted by everyone) until  
Cirkuit has had a release with D14202  so 
we don't wind up with the dreaded "Ambiguous Shortcut!" dialog.
  
  
  Are you sure about that? This might mean waiting forever.
  
  AFAIK Cirkuit did not even have a KF5 release yet, I'd assume everyone is 
just running from the `frameworks` branch, or stuck on an old KDE4 distro which 
would not get the new KConfig anyway. Ubuntu shipped it in 16.04, 18.04 does 
not have it anymore in the default repos. This app is not exactly a second 
DigiKam where your comment might be coming from, with wide distribution and 
regular releases.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Yes, I like it the idea. The chosen shortcut makes sense, and I'm always in 
favor of standardizing these across apps. Let's hold off on landing this patch 
(if accepted by everyone) until  Cirkuit has had a release with D14202 
 so we don't wind up with the dreaded 
"Ambiguous Shortcut!" dialog.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Henrik Fehlauer]

rkflx added a comment.


  @ngraham Would this patch be something you could back?

REPOSITORY
  R237 KConfig

REVISION DETAIL
  https://phabricator.kde.org/D14201

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns

D14201: Set system default shortcut Ctrl+0 for "Actual Size" action

[Peter Mühlenpfordt]

muhlenpfordt created this revision.
muhlenpfordt added reviewers: dfaure, broulik, ngraham.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
muhlenpfordt requested review of this revision.

REVISION SUMMARY
  Default shortcuts for zoom in ([Ctrl] + [+]) and out ([Ctrl] + [-])
  already exists but not for going back to 100%.
  The shortcut [Ctrl] + [0] is widely used by different applications
  for zoom to original size. This patch adds [Ctrl] + [0] as system
  default for `KStandardAction::ActualSize`.

TEST PLAN
  Searched lxr for conflicts of `KStandardAction::ActualSize` and
  usage of Ctrl+0 shortcut.
  Checked the following applications with set system default shortcut:
  
  - Gwenview
  - KAlgebra
  - KolourPaint
  - KStars (FITS viewer)
  - Cirkuit
  
  Only Cirkuit uses Ctrl+0 for "Zoom To Fit" action. I'll create a
  patch to solve this conflict.

REPOSITORY
  R237 KConfig

BRANCH
  shortcut-actual-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D14201

AFFECTED FILES
  src/gui/kstandardshortcut.cpp

To: muhlenpfordt, dfaure, broulik, ngraham
Cc: rkflx, kde-frameworks-devel, michaelh, ngraham, bruns