D14218: Introduce a test to make sure we're not offering duplicated icons

2019-12-05 Thread Aleix Pol Gonzalez 
apol abandoned this revision.
apol added a comment.


  Doesn't seem relevant anymore

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: dfaure, ngraham, andreask, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2019-12-05 Thread Nathaniel Graham 
ngraham added a comment.


  @apol we have a duplicate test in breeze-icons now; is this still relevant?

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: dfaure, ngraham, andreask, kde-frameworks-devel, LeGast00n, GB_2, michaelh, 
bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-08-06 Thread David Faure 
dfaure added inline comments.

INLINE COMMENTS

> kiconloaderdummy.h:1
> +#ifndef KICONLOADERDUMMY_H
> +#define KICONLOADERDUMMY_H

copyright header missing

> kiconloaderdummy.h:9
> +#include 
> +#include 
> +

This includes all of QtTest *plus* all of QtCore. Prefer 

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: dfaure, ngraham, andreask, kde-frameworks-devel, michaelh, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Aleix Pol Gonzalez 
apol added a comment.


  @andreask, thanks for looking into it. Now it's accepted but we'll get a 
bunch of errors, how do you suggest we resolve it? I'd rather have a plan 
before landing this.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: ngraham, andreask, kde-frameworks-devel, michaelh, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Andreas Kainz 
andreaska accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: ngraham, andreask, kde-frameworks-devel, michaelh, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Nathaniel Graham 
ngraham added a comment.


  +1 conceptually.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks
Cc: ngraham, andreask, kde-frameworks-devel, michaelh, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Nathaniel Graham 
ngraham edited reviewers, added: Breeze, Frameworks; removed: Framework: Syntax 
Highlighting.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #breeze, #frameworks, 
#framework_syntax_highlighting
Cc: andreask, kde-frameworks-devel, michaelh, ngraham, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-23 Thread Marco Martin 
mart added a comment.


  +100 from me as well

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting
Cc: andreask, kde-frameworks-devel, michaelh, ngraham, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-20 Thread Aleix Pol Gonzalez 
apol added a subscriber: andreask.
apol added a comment.


  Can someone from the breeze team confirm the issue? If so I'll help find a 
solution.
  
  @andreask?

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting
Cc: andreask, kde-frameworks-devel, michaelh, ngraham, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-19 Thread Volker Krause 
vkrause added a comment.


  +1 on the test, can't comment on how to resolve this unfortunately

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-18 Thread Aleix Pol Gonzalez 
apol edited the test plan for this revision.
apol added reviewers: andreaska, mart, vkrause, Framework: Syntax Highlighting.

REPOSITORY
  R266 Breeze Icons

REVISION DETAIL
  https://phabricator.kde.org/D14218

To: apol, andreaska, mart, vkrause, #framework_syntax_highlighting
Cc: kde-frameworks-devel, michaelh, ngraham, bruns

D14218: Introduce a test to make sure we're not offering duplicated icons

2018-07-18 Thread Aleix Pol Gonzalez 
apol created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: kde-frameworks-devel.
apol requested review of this revision.

REVISION SUMMARY
  At the moment we have them separate in actions, places, applications. This
  distinction is nice but it's not being used in practice. This patch introduces
  a test that will complain when that happens.
  
  This is actually a problem because it makes the whole icons system more 
complex
  than it should be as we found with itinerary.
  
  CCBUG: 396626

REPOSITORY
  R266 Breeze Icons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14218

AFFECTED FILES
  autotests/CMakeLists.txt
  autotests/dupetest.cpp
  autotests/kiconloaderdummy.cpp
  autotests/kiconloaderdummy.h
  autotests/scalabletest.cpp

To: apol
Cc: kde-frameworks-devel, michaelh, ngraham, bruns